Merge lp:~jameinel/juju-core/failing-test into lp:~go-bot/juju-core/trunk

Proposed by John A Meinel
Status: Rejected
Rejected by: William Reade
Proposed branch: lp:~jameinel/juju-core/failing-test
Merge into: lp:~go-bot/juju-core/trunk
Diff against target: 14 lines (+4/-0)
1 file modified
cloudinit/cloudinit_test.go (+4/-0)
To merge this branch: bzr merge lp:~jameinel/juju-core/failing-test
Reviewer Review Type Date Requested Status
Juju Engineering Pending
Review via email: mp+213769@code.launchpad.net

Commit message

This branch should have had a test fail, and not get merged. Something is unhappy in the bot.

Description of the change

This branch should have a test fail, and not get merged.

To post a comment you must log in.
Revision history for this message
Go Bot (go-bot) wrote :
Download full text (324.1 KiB)

The attempt to merge lp:~jameinel/juju-core/failing-test into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.012s
ok launchpad.net/juju-core/agent 1.086s
ok launchpad.net/juju-core/agent/mongo 0.506s
ok launchpad.net/juju-core/agent/tools 0.202s
ok launchpad.net/juju-core/bzr 5.069s
ok launchpad.net/juju-core/cert 3.637s
ok launchpad.net/juju-core/charm 0.366s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]

----------------------------------------------------------------------
FAIL: cloudinit_test.go:309: S.TestFail

cloudinit_test.go:310:
    c.Fatalf("This test should never pass")
... Error: This test should never pass

OOPS: 5 passed, 1 FAILED
--- FAIL: Test1 (0.00 seconds)
FAIL
FAIL launchpad.net/juju-core/cloudinit 0.033s
ok launchpad.net/juju-core/cloudinit/sshinit 0.764s
ok launchpad.net/juju-core/cmd 0.177s
ok launchpad.net/juju-core/cmd/charm-admin 0.734s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/envcmd 0.198s
ok launchpad.net/juju-core/cmd/juju 204.475s
[jujuc whatever]
[remote]
[/path/to/remote]
[remote --help]
[unknown]
[remote --error borken]
[remote --unknown]
[remote unwanted]

----------------------------------------------------------------------
FAIL: unit_test.go:137: UnitSuite.TestRunStop

[LOG] 69.80991 DEBUG juju.environs.configstore Making /tmp/juju-core-test.ARliJS/gocheck-6334824724549167320/18/home/ubuntu/.juju/environments
[LOG] 69.87639 DEBUG juju.environs.tools reading v1.* tools
[LOG] 69.87643 INFO juju environs/testing: uploading FAKE tools 1.19.0-precise-amd64
[LOG] 69.87700 DEBUG juju.environs.tools no architecture specified when finding tools, looking for any
[LOG] 69.87701 DEBUG juju.environs.tools no series specified when finding tools, looking for any
[LOG] 69.87704 DEBUG juju.environs.simplestreams fetchData failed for "tools/streams/v1/index.sjson": file "tools/streams/v1/index.sjson" not found not found
[LOG] 69.87706 DEBUG juju.environs.simplestreams cannot load index "streams/v1/index.sjson": invalid URL "tools/streams/v1/index.sjson" not found
[LOG] 69.87709 DEBUG juju.environs.simplestreams fetchData failed for "tools/streams/v1/index.json": file "tools/streams/v1/index.json" not found not found
[LOG] 69.87710 DEBUG juju.environs.simplestreams cannot load index "streams/v1/index.json": invalid URL "tools/streams/v1/index.json" not found
[LOG] 69.87738 INFO juju.environs.tools Writing tools/streams/v1/index.json
[LOG] 69.87741 INFO juju.environs.tools Writing tools/streams/v1/com.ubuntu.juju:released:tools.json
[LOG] 69.87752 DEBUG juju.environs.bootstrap environment "dummyenv" supports service/machine networks: true
[LOG] 69.87754 INFO juju.environs.bootstrap bootstrapping environment "dummyenv"
[LOG] 69.87756 DEBUG juju.environs.bootstrap looking for bootstrap tools: series="precise", arch=<nil>, version=1.19.0
[LOG] 69.87758 INFO juju.environs.tools reading tools with major.minor version 1.19
[LOG] 69.87759 INFO juju.environs.tools filtering tools by version:...

Revision history for this message
William Reade (fwereade) wrote :

It works, so I rejected it. IYSWIM.

Revision history for this message
John A Meinel (jameinel) wrote :

I reserve the right to submit this again in the future, but it is exactly
what I wanted today. :)

On Wed, Apr 2, 2014 at 2:47 PM, William Reade
<email address hidden>wrote:

> It works, so I rejected it. IYSWIM.
> --
> https://code.launchpad.net/~jameinel/juju-core/failing-test/+merge/213769
> You are the owner of lp:~jameinel/juju-core/failing-test.
>

Unmerged revisions

2524. By John A Meinel

Make sure we have a failing test, so we can be sure the bot will reject the change.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/cloudinit_test.go'
2--- cloudinit/cloudinit_test.go 2014-03-12 11:29:20 +0000
3+++ cloudinit/cloudinit_test.go 2014-04-02 06:39:19 +0000
4@@ -306,6 +306,10 @@
5 })
6 }
7
8+func (S) TestFail(c *gc.C) {
9+ c.Fatalf("This test should never pass")
10+}
11+
12 func (S) TestPackages(c *gc.C) {
13 cfg := cloudinit.New()
14 c.Assert(cfg.Packages(), gc.HasLen, 0)

Subscribers

People subscribed via source and target branches

to status/vote changes: