Merge lp:~james-w/launchpad/fix-webservice-test-isolation into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~james-w/launchpad/fix-webservice-test-isolation |
Merge into: | lp:launchpad |
Diff against target: |
37 lines (+8/-1) 2 files modified
lib/canonical/launchpad/doc/webservice-error.txt (+6/-1) lib/canonical/launchpad/doc/webservice-marshallers.txt (+2/-0) |
To merge this branch: | bzr merge lp:~james-w/launchpad/fix-webservice-test-isolation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | Approve | ||
Review via email: mp+22040@code.launchpad.net |
Commit message
Fix an isolation issue in lib/canonical/
Description of the change
This fixes an issue where webservice-
environment. This meant that webservice-
it ran second, as it normally does. It would fail when run on it's own
though, as the request was never started in that test.
This firstly fixes the isolation issue by having the first test clean
up and finish the request, and then fixes the second test to work
in a clean environment by starting the request again.
The second test already cleans the environment, which is where the error
occurs if you run the test alone.
To test run:
./bin/test -t lib/canonical/
./bin/test -t lib/canonical/
both with and without the change.
Thanks,
James
Thank you, James.