Launchpad itself

Merge lp:~james-w/launchpad/i-love-sync-source into lp:launchpad

  1. i-love-sync-source
  2. Merge into devel
Proposed by James Westby
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~james-w/launchpad/i-love-sync-source
Merge into: lp:launchpad
Diff against target: 18 lines (+2/-2)
1 file modified
scripts/ftpmaster-tools/sync-source.py (+2/-2)
To merge this branch: bzr merge lp:~james-w/launchpad/i-love-sync-source
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Review via email: mp+18485@code.launchpad.net

Commit message

If using sync-source.py without -a then explain why it won't update.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

When doing explicit syncs I want to know why sync-source.py refuses
to do whatever I tell it without having to pass --moreverbose. This
does that.

Thanks,

James

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I assume you know if this is a good idea or not :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/ftpmaster-tools/sync-source.py'
2--- scripts/ftpmaster-tools/sync-source.py 2009-10-19 17:59:47 +0000
3+++ scripts/ftpmaster-tools/sync-source.py 2010-02-02 22:41:13 +0000
4@@ -697,12 +697,12 @@
5 else:
6 if dest_version.find("ubuntu") != -1:
7 stat_uptodate_modified += 1
8- if Options.moreverbose:
9+ if Options.moreverbose or not Options.all:
10 print ("[Nothing to update (Modified)] %s_%s (vs %s)"
11 % (pkg, dest_version, source_version))
12 else:
13 stat_uptodate += 1
14- if Options.moreverbose:
15+ if Options.moreverbose or not Options.all:
16 print (
17 "[Nothing to update] %s (%s [ubuntu] >= %s [debian])"
18 % (pkg, dest_version, source_version))