Merge lp:~james-w/python-launchpad-bugs/urlerror-reason into lp:python-launchpad-bugs

Proposed by James Westby
Status: Merged
Merged at revision: not available
Proposed branch: lp:~james-w/python-launchpad-bugs/urlerror-reason
Merge into: lp:python-launchpad-bugs
To merge this branch: bzr merge lp:~james-w/python-launchpad-bugs/urlerror-reason
Reviewer Review Type Date Requested Status
Markus Korn Approve
Brian Murray Approve
Review via email: mp+2723@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

This change should make errors more descriptive when we get an
unknown response from Launchpad.

URLError has a subclass, HTTPError, which has a .code attribute, and
is raised most often, but the base class doesn't have this.

The code also checks for this, but doesn't make use of the .reason
attribute on the base class, which is probably more descriptive than
"unknown error".

Thanks,

James

173. By James Westby

Don't overwrite the original error when AttributeError is caught.

Revision history for this message
Brian Murray (brian-murray) :
review: Approve
Revision history for this message
Markus Korn (thekorn) wrote :

looks good to me, will merge this later today

Revision history for this message
Markus Korn (thekorn) :
review: Approve

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: