Merge lp:~james-w/python-launchpad-bugs/urlerror-reason into lp:python-launchpad-bugs
Proposed by
James Westby
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~james-w/python-launchpad-bugs/urlerror-reason |
Merge into: | lp:python-launchpad-bugs |
To merge this branch: | bzr merge lp:~james-w/python-launchpad-bugs/urlerror-reason |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Markus Korn | Approve | ||
Brian Murray | Approve | ||
Review via email: mp+2723@code.launchpad.net |
To post a comment you must log in.
Hi,
This change should make errors more descriptive when we get an
unknown response from Launchpad.
URLError has a subclass, HTTPError, which has a .code attribute, and
is raised most often, but the base class doesn't have this.
The code also checks for this, but doesn't make use of the .reason
attribute on the base class, which is probably more descriptive than
"unknown error".
Thanks,
James