Merge lp:~jcsackett/launchpad/deprecate-official_codehosting into lp:launchpad
Status: | Merged |
---|---|
Approved by: | j.c.sackett |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11484 |
Proposed branch: | lp:~jcsackett/launchpad/deprecate-official_codehosting |
Merge into: | lp:launchpad |
Diff against target: |
330 lines (+72/-30) 8 files modified
lib/lp/registry/adapters.py (+18/-2) lib/lp/registry/browser/distribution.py (+2/-1) lib/lp/registry/browser/pillar.py (+16/-7) lib/lp/registry/browser/productseries.py (+11/-3) lib/lp/registry/browser/tests/pillar-views.txt (+8/-8) lib/lp/registry/browser/tests/productseries-views.txt (+4/-4) lib/lp/registry/configure.zcml (+7/-0) lib/lp/registry/stories/product/xx-product-launchpad-usage.txt (+6/-5) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/deprecate-official_codehosting |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+33953@code.launchpad.net |
Commit message
Replaces use of official_
Description of the change
= Summary =
Replaces use of official_
== Proposed fix ==
Where official_
== Pre-implementation notes ==
Spoke with Curtis.
== Implementation details ==
As in Proposed fix.
== Tests ==
bin/test -vvc -t productseries-
bin/test -vvc -t pillar-views.txt
bin/test -vvc -t distribution-
== Demo and Q/A ==
Check out a project, product and distribution on launchpad.dev.
Everything should function as before--this shouldn't have introduced
any visible changes.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
This branch looks nice Jon. What would you think of creating some helper functions like:
uses_Launchpad( thing)
You could then collapse this:
175 + if self.codehostin g_usage == ServiceUsage. LAUNCHPAD: set_branch, configured) ]
176 + configured = True
177 + else:
178 + configured = False
179 return [dict(link=
181 + configured=
to:
179 return [dict(link= set_branch, uses_launchpad( self.codehostin g_usage)
181 + configured=
I guess you could do the same with:
configured = (self.codehosti ng_usage == ServiceUsage. LAUNCHPAD)
with less overhead.