Launchpad itself

Merge lp:~jcsackett/launchpad/launchpad-ids-270310 into lp:launchpad

  1. launchpad-ids-270310
  2. Merge into devel
Proposed by j.c.sackett
Status: Merged
Merged at revision: 12004
Proposed branch: lp:~jcsackett/launchpad/launchpad-ids-270310
Merge into: lp:launchpad
Diff against target: 22 lines (+5/-0)
1 file modified
lib/lp/registry/templates/person-portlet-contact-details.pt (+5/-0)
To merge this branch: bzr merge lp:~jcsackett/launchpad/launchpad-ids-270310
Reviewer Review Type Date Requested Status
Curtis Hovey (community) ui Approve
Graham Binns (community) code Approve
Review via email: mp+42190@code.launchpad.net

Commit message

[r=gmb][ui=sinzui][bug=270310] Adds launchpad id to the person overview.

Description of the change

Summary
=======
Launchpad id, while displayed in the url and the +edit view (and as part of the login data on the left), isn't actually displayed on a users page. Given that documentation references a "launchpad id" and nothing is called this on the user page, a bug was confirmed to add that to the overview.

Trivially, this branch adds an entry for Launchpad id on the contact portlet.

Demo & QA
=========
Go to launchpad.dev/~mark. An entry of Launchpad id exists with the data "mark".

A screenshot is here: http://people.canonical.com/~jc/images/launchpad-id.png

Lint
====

make lint output:

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/templates/person-portlet-contact-details.pt

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve (code)
Revision history for this message
Curtis Hovey (sinzui) wrote :

We want to use "Id" (http://en.wikipedia.org/wiki/Id.). I think Launchpad Id should be the first item in the portlet. Everyone has one, but email address will often not show when the user hides them.

I believe that fixing this will escalate other issues. I can see my Launchpad Id, but I cannot change it because the field label is Name. Maybe we can replace name with Launchpad Id (and remove title) from all forms in two weeks.

review: Approve (ui)
Revision history for this message
j.c.sackett (jcsackett) wrote :

> We want to use "Id" (http://en.wikipedia.org/wiki/Id.). I think Launchpad Id should be the first item in the portlet. Everyone has one, but email address will often not show when the user hides them.

All taken care of.

> I believe that fixing this will escalate other issues. I can see my Launchpad Id, but I cannot change it because the field label is Name. Maybe we can replace name with Launchpad Id (and remove title) from all forms in two weeks.

Not a bad plan--should I go ahead and file a ticket against that?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
2--- lib/lp/registry/templates/person-portlet-contact-details.pt 2010-08-16 13:14:31 +0000
3+++ lib/lp/registry/templates/person-portlet-contact-details.pt 2010-11-30 17:01:25 +0000
4@@ -10,6 +10,10 @@
5 <h2>User information</h2>
6
7 <div class="first yui-u">
8+ <dl id="launchpad-id">
9+ <dt>Launchpad Id:</dt>
10+ <dd tal:content="context/name"/>
11+ </dl>
12 <dl id="email-addresses">
13 <dt>Email:
14 <a tal:replace="structure overview_menu/editemailaddresses/fmt:icon" />
15@@ -47,6 +51,7 @@
16 </dd>
17 </dl>
18
19+
20 <dl tal:condition="view/should_show_jabberids_section" id="jabber-ids">
21 <dt>Jabber:
22 <a tal:replace="structure overview_menu/editjabberids/fmt:icon" />