Merge lp:~jcsackett/launchpad/project-involvement-translations-contradiction-652287 into lp:launchpad
Status: | Merged |
---|---|
Merged at revision: | 11687 |
Proposed branch: | lp:~jcsackett/launchpad/project-involvement-translations-contradiction-652287 |
Merge into: | lp:launchpad |
Diff against target: |
88 lines (+38/-0) 4 files modified
lib/lp/registry/browser/pillar.py (+4/-0) lib/lp/registry/browser/tests/pillar-views.txt (+25/-0) lib/lp/registry/interfaces/projectgroup.py (+4/-0) lib/lp/registry/model/projectgroup.py (+5/-0) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/project-involvement-translations-contradiction-652287 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+37763@code.launchpad.net |
Commit message
Updates the involvement menu for translations on project groups to reflect the status of translatable products within the project.
Description of the change
Summary
=======
Updates the involvement menu for translations on project groups to reflect the
status of translatable products within the project.
Proposed fix
============
Update project groups involvement menu to include the translatable products
conditions.
Pre-implementation notes
=======
Spoke with Curtis about the intent. Spoke with Danilos about what "translatable"
means in this context.
Implementation details
=======
Largely as in proposed; translations_usage on the projectgroup view is
overridden to UNKNOWN in the instance that no products are in the project
group's 'translatables' list.
Tests
=====
bin/test -t pillar-views
Demo and Q/A
============
On launchpad.
no longer enabled. If you set up one of the mozilla products for translations,
it will become enabled.
Lint
====
make lint output:
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
321: undefined name 'OfficialBugTag'
I'm not sure what's up with the OfficialBugTag issue. It occurs in storm query and isn't part of my branch. I'm happy to fix it, if it's something that needs fixing, but I wasn't sure of what's expected there.
Hi JC,
This is a nice improvement. I just have a couple of comments below.
-Edwin
>Lint: registry/ model/projectgr oup.py
> ./lib/lp/
> 321: undefined name 'OfficialBugTag'
>
>I'm not sure what's up with the OfficialBugTag issue. It occurs in storm
>query and isn't part of my branch. I'm happy to fix it, if it's
>something that needs fixing, but I wasn't sure of what's expected there.
That method isn't being used yet due to bug 341203. Please add the
import statement so the lint error goes away.
>=== modified file 'lib/lp/ registry/ interfaces/ projectgroup. py' registry/ interfaces/ projectgroup. py 2010-09-22 08:48:24 +0000 registry/ interfaces/ projectgroup. py 2010-10-06 18:04:51 +0000 official_ rosetta flag set. es():
>--- lib/lp/
>+++ lib/lp/
>@@ -320,6 +320,10 @@
> It also should have IProduct.
> """
>
>+ def has_translatabl
>+ """Return a boolean showing the existance of translatables products.
s/translatables /translatable/
>+ """
>+
> def hasProducts():
> """Returns True if a project has products associated with it, False
> otherwise.
>