Merge lp:~jcsackett/launchpad/remove-cache-private-650668 into lp:launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gavin Panella | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11674 | ||||
| Proposed branch: | lp:~jcsackett/launchpad/remove-cache-private-650668 | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: |
33 lines (+1/-4) 2 files modified
lib/lp/registry/templates/person-related-software.pt (+0/-2) lib/lp/registry/templates/productseries-milestone-table-row.pt (+1/-2) |
||||
| To merge this branch: | bzr merge lp:~jcsackett/launchpad/remove-cache-private-650668 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Removes instances of cache:private in the registry templates.
Description of the change
Summary
=======
Removes the two instances of cache:private in the registry app, as they're unneeded and cause errors.
Proposed Fix
============
Remove the two instances the cache:private directive is used in the registry templates.
Pre-Implementation Talk
=======
Spoke with Curtis Hovey.
Implementation details
=======
As in proposed.
Tests
=====
bin/test -t TestMilestoneViews
bin/test -t test_person_views
bin/test -t TestProductSeri
Demo and Q/A
============
Related software on a ~person page should still show normally; productseries and milestone views should all show up normally.
Lint
====
make lint output:
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Looks good.