lp:~jjacobs/methanal/verified-password-input
- Get this branch:
- bzr branch lp:~jjacobs/methanal/verified-password-input
Branch merges
- Tristan Seligmann: Approve
- Forrest Aldridge (community): Needs Fixing
-
Diff: 306 lines4 files modifiedmethanal/js/Methanal/Tests/TestView.js (+119/-5)
methanal/js/Methanal/View.js (+91/-0)
methanal/themes/methanal-base/methanal-verified-password-input.html (+15/-0)
methanal/view.py (+32/-0)
Related bugs
Bug #444737: There is no input widget for passwords | Low | Fix Released |
Related blueprints
Branch information
Recent revisions
- 109. By Forrest Aldridge
-
Addressed all code review points:
1. Fixed.
2. Fixed.
3. Fixed.
4. Fixed.
5. Fixed. Hey, that was your code, jonathanj, btw. ;)
6. Fixed. - 108. By Forrest Aldridge
-
VerifiedPasswor
dInput. __init_ _() method now sets the control's
_confirmPasswordNode before upcalling. Fix bug in the unit test. Now calling self.assertInva
lidInput( ), rather
than trying to call control.assertInvalidIn put(). All unit tests now pass.
- 107. By Forrest Aldridge
-
Fixed the test_inputValiation test case to reflect making 'confirmPasswor
dNode'
a private attribute. Still broken, though. - 106. By Forrest Aldridge
-
1. Improved the Python and JavaScript docstrings.
2. Changed the overridden createControl() method for the test_inputValidation
test case to upcall createControl(), instead of duplicating its logic. - 105. By Forrest Aldridge
-
Added a VerifiedPasswor
dInput with unit test. Unit test is currently failing and I'm not sure why. Need some feedback on
this one.
Branch metadata
- Branch format:
- Branch format 6
- Repository format:
- Bazaar pack repository format 1 (needs bzr 0.92)