publish-bot

Merge lp:~jkakar/publish-bot/channel-password into lp:publish-bot

  1. channel-password
  2. Merge into trunk
Proposed by Jamu Kakar
Status: Needs review
Proposed branch: lp:~jkakar/publish-bot/channel-password
Merge into: lp:publish-bot
To merge this branch: bzr merge lp:~jkakar/publish-bot/channel-password
Reviewer Review Type Date Requested Status
Christopher Armstrong Pending
Review via email: mp+47990@code.launchpad.net

This proposal supersedes a proposal from 2011-01-20.

Description of the change

This branch introduces the following changes:

- An optional 'message_channel_password' configuration option can be
  defined in ~/.bazaar/locations.conf. When present, its used by
  publish-bot when joining the specified channel.

To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote : Posted in a previous version of this proposal

Also, to confirm, I tested this on Freenode and it works as
advertised.

Revision history for this message
Jamu Kakar (jkakar) wrote :

I discovered an interesting problem with this branch. It adds the
channel password by introducing another colon in the format. This
causes old publish-bot's, or other code (such as mup) that understand
the publish-bot protocol, to print messages where every line starts
with a colon.

I wonder if I should, instead of using a colon, represent the channel
and password as <channel>|<password>, or something. And then split
the channel name on '|' to see if there's a password.

Reply
Revision history for this message
Thomas Herve (therve) wrote :

Or you can simply count the number of colon? And keep the old format when there is no password.

Reply
lp:~jkakar/publish-bot/channel-password updated
17. By Jamu Kakar

- Changed the message format to be backwards compatible with the
  existing publishbot protocol.

Revision history for this message
Jamu Kakar (jkakar) wrote :

I've changed the format to be backwards compatible with the existing
format. Please review.

Reply
lp:~jkakar/publish-bot/channel-password updated
18. By Jamu Kakar

- Fixed stupid bug.

Unmerged revisions

18. By Jamu Kakar

- Fixed stupid bug.

17. By Jamu Kakar

- Changed the message format to be backwards compatible with the
  existing publishbot protocol.

16. By Jamu Kakar

- Added support for channel passwords.

Subscribers

People subscribed via source and target branches

to all changes: