Merge lp:~jml/canonical-identity-provider/remove-unnecessary-loaddata into lp:canonical-identity-provider/release

Proposed by Jonathan Lange
Status: Merged
Approved by: Natalia Bidart
Approved revision: no longer in the source branch.
Merged at revision: 554
Proposed branch: lp:~jml/canonical-identity-provider/remove-unnecessary-loaddata
Merge into: lp:canonical-identity-provider/release
Diff against target: 12 lines (+0/-3)
1 file modified
tarmac_tests.sh (+0/-3)
To merge this branch: bzr merge lp:~jml/canonical-identity-provider/remove-unnecessary-loaddata
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+139672@code.launchpad.net

Commit message

Remove unnecessary loaddata from tarmac test run.

Description of the change

It turns out that the 'loaddata' part of tarmac_tests.sh does not prevent
the "Connection timed out" warnings and is not necessary for the tests to
pass.

What is not necessary and not beneficial must be destroyed.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Agreed!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tarmac_tests.sh'
2--- tarmac_tests.sh 2012-12-12 16:04:15 +0000
3+++ tarmac_tests.sh 2012-12-13 11:47:19 +0000
4@@ -13,8 +13,5 @@
5 sed -i 's/db_host = .*/db_host =/g' django_project/local.cfg
6 fab resetdb >> $LOG_FILE
7
8-# The functional tests depend on some data found in the fixtures.
9-fab manage:"loaddata test"
10-
11 # run tests
12 fab test