Merge lp:~jml/canonical-identity-provider/tarmac-tests into lp:canonical-identity-provider/release

Proposed by Jonathan Lange
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: no longer in the source branch.
Merged at revision: 550
Proposed branch: lp:~jml/canonical-identity-provider/tarmac-tests
Merge into: lp:canonical-identity-provider/release
Diff against target: 14 lines (+10/-0)
1 file modified
tarmac_tests.sh (+10/-0)
To merge this branch: bzr merge lp:~jml/canonical-identity-provider/tarmac-tests
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Vincent Ladeuil (community) Approve
Review via email: mp+139193@code.launchpad.net

Commit message

Add tarmac_tests.sh, so CI tests are controlled from the branch

Description of the change

One thing that's worked well for us is having a script in the branch
that is solely dedicated to running the pre-merge tests. Jenkins is
configured to tell tarmac to run this script.

That way, once pre-merge testing is set up, the way that tests are run
can itself be changed with a guarantee that it will only get through to
trunk if it continues to work.

It also provides handy version control for this key part of the
configuration.

cheers,
jml

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

+1 on the idea, the more we control the tests we run (and *how* to run them and why we change that) the better.

review: Approve
Revision history for this message
Jonathan Lange (jml) wrote :

Update for pindonga's suggestion.

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM. We might want to put this script along with the others in ./scripts

review: Approve
Revision history for this message
Jonathan Lange (jml) wrote :

On 11 December 2012 18:21, Ricardo Kirkner
<email address hidden> wrote:
> Review: Approve
>
> LGTM. We might want to put this script along with the others in ./scripts

Our other projects that use this approach have it in the top-level. If
we leave it there, then Jenkins admin requires a little bit less
thinking.

jml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'tarmac_tests.sh'
2--- tarmac_tests.sh 1970-01-01 00:00:00 +0000
3+++ tarmac_tests.sh 2012-12-11 17:59:23 +0000
4@@ -0,0 +1,10 @@
5+#!/bin/sh
6+# How the tests are run in Jenkins by Tarmac
7+
8+set -e
9+
10+LOG_FILE=log
11+
12+echo "Running canonical-identity-provider tests in tarmac" > $LOG_FILE
13+fab bootstrap >> $LOG_FILE
14+fab test