Merge lp:~jml/launchpad/link-to-lp-revision into lp:launchpad

Proposed by Jonathan Lange
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 11273
Proposed branch: lp:~jml/launchpad/link-to-lp-revision
Merge into: lp:launchpad
Diff against target: 15 lines (+4/-1)
1 file modified
lib/lp/app/templates/base-layout-macros.pt (+4/-1)
To merge this branch: bzr merge lp:~jml/launchpad/link-to-lp-revision
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+31310@code.launchpad.net

Description of the change

This branch changes the footer on edge to link to the Launchpad stable branch.

The way I've done the change is kind of crappy. I welcome suggestions on how to do it better.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Hi Jono,

I don't have any suggestions for doing it better. But I wonder why you want a link to the branch here to the stable branch instead of to the devel branch or even https://dev.launchpad.net/Getting

review: Needs Information (code)
Revision history for this message
Jonathan Lange (jml) wrote :

On Fri, Jul 30, 2010 at 3:21 PM, Brad Crittenden <email address hidden> wrote:
> Review: Needs Information code
> Hi Jono,
>
> I don't have any suggestions for doing it better.  But I wonder why you want a link to the branch here to the stable branch instead of to the devel branch or even https://dev.launchpad.net/Getting

The devel branch has very little to do with what's on edge, and is to
my mind merely a convenient mechanism for queueing up changes to the
stable branch. To put it another way, why would we link to broken code
when we can link to a known-good branch?

I don't link to Getting because part of the motivation for the link is
to make it easy to see a revision log. I don't know whether that's a
good enough reason.

Thanks for the review.
jml

Revision history for this message
Brad Crittenden (bac) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
2--- lib/lp/app/templates/base-layout-macros.pt 2010-07-21 14:20:33 +0000
3+++ lib/lp/app/templates/base-layout-macros.pt 2010-07-29 17:47:47 +0000
4@@ -428,7 +428,10 @@
5 r<tal:revno replace="revno" />
6 <tal:devmode condition="devmode">devmode</tal:devmode>
7 <tal:demo condition="is_demo">demo site</tal:demo>
8- <tal:edge condition="is_edge">beta site</tal:edge>
9+ <tal:edge condition="is_edge">
10+ beta site (<a href="https://code.edge.launchpad.net/~launchpad-pqm/launchpad/stable/"
11+ >get the code</a>)
12+ </tal:edge>
13 </span>
14 </div>
15 </div>