Launchpad itself

Merge lp:~jml/launchpad/more-cleanups into lp:launchpad

  1. more-cleanups
  2. Merge into devel
Proposed by Jonathan Lange
Status: Merged
Approved by: Jonathan Lange
Approved revision: no longer in the source branch.
Merged at revision: 13348
Proposed branch: lp:~jml/launchpad/more-cleanups
Merge into: lp:launchpad
Diff against target: 0 lines
To merge this branch: bzr merge lp:~jml/launchpad/more-cleanups
Reviewer Review Type Date Requested Status
Jonathan Lange (community) Approve
Review via email: mp+66288@code.launchpad.net

Commit message

[r=jml][no-qa] Remove canonical.launchpad.ftests._sqlobject

Description of the change

This branch aims to remove the _sqlobject module, which is used only for testing.

 * sync() is killed, most call sites just didn't need to call it. Those that did have been replaced with a storm flush.
 * print_date_attribute has been deleted, and the two doctests that relied on it have had chunks converted to unit tests (if equivalent unit tests already)
 * set_so_attr() wasn't used

There's also various flakes cleanup.

Tests are running now.

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Looks good to me.

review: Approve

Preview Diff

Empty