Launchpad itself

Merge lp:~jml/launchpad/remove-bugbranch-from-sampledata into lp:launchpad

  1. remove-bugbranch-from-sampledata
  2. Merge into devel
Proposed by Jonathan Lange
Status: Rejected
Rejected by: Jonathan Lange
Proposed branch: lp:~jml/launchpad/remove-bugbranch-from-sampledata
Merge into: lp:launchpad
Prerequisite: lp:~jml/launchpad/branch-sample-data-doctests
Diff against target: 18 lines (+0/-8)
1 file modified
database/sampledata/current.sql (+0/-8)
To merge this branch: bzr merge lp:~jml/launchpad/remove-bugbranch-from-sampledata
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+31321@code.launchpad.net

Commit message

Remove BugBranch sample data

Description of the change

Remove BugBranch rows from the test sample data. They are unused.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

I'm surprised we don't have a rule about only doing sample data changes against db-devel, not devel. It *seems* like it would be safer, especially given the Postgres 8.3 vs 8.4 fight that completely rewrites the files, if we did changes in only db-devel.

Thoughts?

review: Approve (code)
Revision history for this message
Jonathan Lange (jml) wrote :

On Fri, Jul 30, 2010 at 3:35 PM, Brad Crittenden <email address hidden> wrote:
> Review: Approve code
> I'm surprised we don't have a rule about only doing sample data changes against db-devel, not devel.  It *seems* like it would be safer, especially given the Postgres 8.3 vs 8.4 fight that completely rewrites the files, if we did changes in only db-devel.

If we have a rule, it'll be enforced by the Makefile. I'm happy to try
landing against devel first and try again with db-devel if it fails.

Thanks for the review.
jml

Revision history for this message
Jonathan Lange (jml) wrote :

Thanks, but it turns out this branch isn't ready to land yet. We still have tests that use BugBranch sample data.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'database/sampledata/current.sql'
2--- database/sampledata/current.sql 2010-07-13 15:29:08 +0000
3+++ database/sampledata/current.sql 2010-07-29 19:49:51 +0000
4@@ -3242,14 +3242,6 @@
5 ALTER TABLE bugattachment ENABLE TRIGGER ALL;
6
7
8-ALTER TABLE bugbranch DISABLE TRIGGER ALL;
9-
10-INSERT INTO bugbranch (id, datecreated, bug, branch, revision_hint, whiteboard, registrant) VALUES (1, '2006-03-22 18:44:27.438982', 5, 1, NULL, NULL, 12);
11-INSERT INTO bugbranch (id, datecreated, bug, branch, revision_hint, whiteboard, registrant) VALUES (2, '2006-03-22 18:45:08.75694', 4, 10, NULL, NULL, 1);
12-INSERT INTO bugbranch (id, datecreated, bug, branch, revision_hint, whiteboard, registrant) VALUES (3, '2006-03-22 18:45:50.344434', 4, 1, NULL, NULL, 12);
13-
14-
15-ALTER TABLE bugbranch ENABLE TRIGGER ALL;
16
17
18 ALTER TABLE cve DISABLE TRIGGER ALL;