langpack-o-matic

Merge lp:~jr/langpack-o-matic/no-kde-lang-pack into lp:langpack-o-matic

  1. no-kde-lang-pack
  2. Merge into main
Proposed by Jonathan Riddell
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~jr/langpack-o-matic/no-kde-lang-pack
Merge into: lp:langpack-o-matic
Diff against target: 11 lines (+0/-2)
1 file modified
lib/pkg_classify.py (+0/-2)
To merge this branch: bzr merge lp:~jr/langpack-o-matic/no-kde-lang-pack
Reviewer Review Type Date Requested Status
Martin Pitt (community) Disapprove
Review via email: mp+111010@code.launchpad.net

Description of the change

remove kde category of language packs

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

What is the particular point of this? This will cause the KDE translations to go into the main language-pack-XX packages. Once all of KDE gets rebuilt in universe, then there should not be any of them left in main in LP translations. Until then we should certainly keep the kde langpacks to avoid regressing translations for Quantal users?

review: Needs Information
Revision history for this message
Jonathan Riddell (jr) wrote :

I hope to replace the language-pack-kde-xx packages with simple meta packages which pull in kde-l10n-xx, calligra-l10n-xx and whatever else is needed
http://people.ubuntu.com/~jr/

So I'd like langpack-o-matic to stop producing language-pack-kde-xx at all

Revision history for this message
Martin Pitt (pitti) wrote :

We need to do this in a way which remains compatible with earlier releases, so we need a version check.

Fixed in http://bazaar.launchpad.net/~ubuntu-langpack/langpack-o-matic/main/revision/429

review: Disapprove

Unmerged revisions

426. By Jonathan Riddell

remove kde category of language packs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/pkg_classify.py'
2--- lib/pkg_classify.py 2011-06-09 06:32:37 +0000
3+++ lib/pkg_classify.py 2012-06-19 13:02:20 +0000
4@@ -125,8 +125,6 @@
5 has_kde = 'kde' in desc or 'qt4' in desc
6 if has_gnome and not has_kde:
7 return 'gnome'
8- elif has_kde and not has_gnome:
9- return 'kde'
10 else:
11 return ''
12

Subscribers

People subscribed via source and target branches