Hi Jeroen,

Thanks for all the multiple drive-by's!

r=me, but two thoughts. The first is general - is there not a better way to handle
these translation credits so that they're not translatable messages
at all? I guess not, otherwise you would have done it.

Second thought: you said in your cover letter that "translations are made
by persons, not teams", but translations are still displayed for other
teams - just not the rosetta experts, is that right?
(eg. http://pastebin.ubuntu.com/328399/), if so, why? (just for my
understanding) 

> === modified file 'lib/lp/translations/browser/person.py'
> --- lib/lp/translations/browser/person.py	2009-09-17 20:11:48 +0000
> +++ lib/lp/translations/browser/person.py	2009-11-26 10:47:06 +0000
> @@ -215,6 +215,8 @@
>      @property
>      def person_is_translator(self):
>          """Is this person active in translations?"""
> +        if self.context.isTeam():
> +            return False
>          person = ITranslationsPerson(self.context)
>          history = person.getTranslationHistory(self.history_horizon).any()
>          return history is not None
> 
> === modified file 'lib/lp/translations/doc/pofile.txt'
> --- lib/lp/translations/doc/pofile.txt	2009-10-29 17:46:00 +0000
> +++ lib/lp/translations/doc/pofile.txt	2009-11-26 10:47:06 +0000
> @@ -1031,8 +1031,17 @@
>  The 'contributors' property of a POFile returns all the people who contributed
>  translations to it.
>  
> -    >>> [person.name for person in evolution_es.contributors]
> -    [u'carlos', u'mark', u'no-priv']
> +    >>> def print_names(persons):
> +    ...     """Print name for each of `persons`."""
> +    ...     for person in persons:
> +    ...         print person.name
> +    ...     print "--"
> +
> +    >>> print_names(evolution_es.contributors)
> +    carlos
> +    mark
> +    no-priv
> +    --
>  
>  If you have a distroseries and want to know all the people who contributed
>  translations on a given language for that distroseries, you can use
> @@ -1042,9 +1051,16 @@
>      >>> from lp.registry.model.distroseries import DistroSeries
>      >>> hoary = DistroSeries.selectOneBy(name="hoary")
>      >>> spanish = Language.selectOneBy(code="es")
> -    >>> [p.name for p in hoary.getPOFileContributorsByLanguage(spanish)]
> -    [u'jorge-gonzalez-gonzalez', u'carlos', u'valyag', u'danner', u'name16',
> -     u'name12', u'ubuntu-translators', u'tsukimi']
> +    >>> print_names(hoary.getPOFileContributorsByLanguage(spanish))
> +    jorge-gonzalez-gonzalez
> +    carlos
> +    valyag
> +    danner
> +    name16
> +    name12
> +    ubuntu-translators
> +    tsukimi
> +    --
>  
>      # We can see that there is another translator that doesn't appear in
>      # previous list because the template he translated is not current.
> @@ -1052,8 +1068,9 @@
>      >>> non_current_pofile.potemplate.iscurrent
>      False
>  
> -    >>> [p.name for p in non_current_pofile.contributors]
> -    [u'jordi']
> +    >>> print_names(non_current_pofile.contributors)
> +    jordi
> +    --
>  
>      >>> non_current_pofile.potemplate.distroseries == hoary
>      True
> @@ -1061,6 +1078,17 @@
>      >>> non_current_pofile.language == spanish
>      True
>  
> +The rosetta_experts team is special: it never shows up in contributors
> +lists.
> +
> +    >>> experts_pofile = factory.makePOFile('nl')
> +    >>> experts_message = factory.makeTranslationMessage(
> +    ...     pofile=experts_pofile, translator=rosetta_experts,
> +    ...     reviewer=rosetta_experts, translations=['hi'])
> +
> +    >>> print_names(experts_pofile.contributors)
> +    --
> +
>  
>  == getPOTMsgSetTranslated ==
>  
> @@ -1191,7 +1219,6 @@
>      Happy translator
>      Launchpad Contributions:
>      Carlos ...
> -    Rosetta Administrators...
>  
>  Emails of translators just has the dummy translation.
>  
> @@ -1210,7 +1237,7 @@
>  
>      >>> print alsa_translation.prepareTranslationCredits(
>      ...     emails_of_translators)
> -    ,,<email address hidden>,<email address hidden>
> +    ,,<email address hidden>
>  
>  Names of translators just has the dummy translation.
>  
> @@ -1228,7 +1255,7 @@
>  
>      >>> print alsa_translation.prepareTranslationCredits(
>      ...     names_of_translators)
> -    ,Launchpad Contributions:,Carlos P... M...,Rosetta Administrators
> +    ,Launchpad Contributions:,Carlos P... M...
>  
>  Lets add a newly supported KDE context message with credit strings
>  split into two: context and message, instead of a single message with
> @@ -1241,7 +1268,7 @@
>  prepareTranslationCredits works on such messages as well:
>  
>      >>> print alsa_translation.prepareTranslationCredits(new_kde_name_credits)
> -    ,Launchpad Contributions:,Carlos P... M...,Rosetta Administrators
> +    ,Launchpad Contributions:,Carlos P... M...
>  
>  Similar happens for email credits as with name credits.
>  
> @@ -1249,7 +1276,7 @@
>      ...     singular_text=u"Your emails", plural_text=None,
>      ...     context=u"EMAIL OF TRANSLATORS")
>      >>> print alsa_translation.prepareTranslationCredits(new_kde_email_credits)
> -    ,,<email address hidden>,<email address hidden>
> +    ,,<email address hidden>
>  
>  
>  == POFileToTranslationFileDataAdapter ==
> 
> === modified file 'lib/lp/translations/model/pofile.py'
> --- lib/lp/translations/model/pofile.py	2009-11-17 09:50:33 +0000
> +++ lib/lp/translations/model/pofile.py	2009-11-26 10:47:06 +0000
> @@ -36,6 +36,7 @@
>  from canonical.launchpad.webapp.publisher import canonical_url
>  from canonical.librarian.interfaces import ILibrarianClient
>  from lp.registry.interfaces.person import validate_public_person
> +from lp.registry.model.person import Person
>  from lp.translations.utilities.rosettastats import RosettaStats
>  from lp.translations.interfaces.pofile import IPOFile, IPOFileSet
>  from lp.translations.interfaces.potmsgset import (
> @@ -504,10 +505,15 @@
>      @property
>      def contributors(self):
>          """See `IPOFile`."""
> -        from lp.registry.model.person import Person
> +        # Translation credit messages are "translated" by
> +        # rosetta_experts.  Shouldn't show up in contributors lists
> +        # though.
> +        admin_team = getUtility(ILaunchpadCelebrities).rosetta_experts
> +
>          contributors = Person.select("""
>              POFileTranslator.person = Person.id AND
> -            POFileTranslator.pofile = %s""" % quote(self),
> +            POFileTranslator.person <> %s AND
> +            POFileTranslator.pofile = %s""" % sqlvalues(admin_team, self),
>              clauseTables=["POFileTranslator"],
>              distinct=True,
>              # XXX: kiko 2006-10-19:
> @@ -516,6 +522,7 @@
>              # function to the column results and then ignore it -- just
>              # like selectAlso does, ironically.
>              orderBy=["Person.displayname", "Person.name"])
> +
>          return contributors
>  
>      def prepareTranslationCredits(self, potmsgset):
> 
> === modified file 'lib/lp/translations/model/potmsgset.py'
> --- lib/lp/translations/model/potmsgset.py	2009-11-11 11:29:09 +0000
> +++ lib/lp/translations/model/potmsgset.py	2009-11-26 10:47:06 +0000
> @@ -1053,17 +1053,20 @@
>  
>      def setTranslationCreditsToTranslated(self, pofile):
>          """See `IPOTMsgSet`."""
> -        if self.is_translation_credit:
> -            translation = self.getSharedTranslationMessage(pofile.language)
> -            if translation is None:
> -                translator = pofile.lasttranslator
> -                if translator is None:
> -                    translator = pofile.owner
> -                message = self.updateTranslation(
> -                    pofile, translator, [credits_message_str],
> -                    is_imported=False, allow_credits=True,
> -                    force_shared=True, force_edition_rights=True,
> -                    lock_timestamp=datetime.datetime.now(pytz.UTC))
> +        if not self.is_translation_credit:
> +            return
> +
> +        if self.getSharedTranslationMessage(pofile.language) is not None:
> +            return

Nice switch to guard code :)

> +
> +        # The credits message has a fixed "translator."
> +        translator = getUtility(ILaunchpadCelebrities).rosetta_experts
> +
> +        message = self.updateTranslation(
> +            pofile, translator, [credits_message_str],
> +            is_imported=False, allow_credits=True,
> +            force_shared=True, force_edition_rights=True,
> +            lock_timestamp=datetime.datetime.now(pytz.UTC))
>  
>      def setSequence(self, potemplate, sequence):
>          """See `IPOTMsgSet`."""
> 
> === modified file 'lib/lp/translations/stories/standalone/xx-translations-to-complete.txt'
> --- lib/lp/translations/stories/standalone/xx-translations-to-complete.txt	2009-08-31 13:55:35 +0000
> +++ lib/lp/translations/stories/standalone/xx-translations-to-complete.txt	2009-11-26 10:47:06 +0000
> @@ -62,3 +62,28 @@
>      ...     pierre_browser.contents, 'translations-to-complete-table')
>      >>> print tag
>      None
> +
> +
> +Teams
> +-----
> +
> +The Rosetta administrators, as a special case, can act as a translator
> +for automatically generated messages.  Nevertheless, its Translations
> +page does not show any translations to complete--even to a member of the team.
> +
> +    >>> login('<email address hidden>')
> +    >>> from zope.component import getUtility
> +    >>> from canonical.launchpad.interfaces.launchpad import (
> +    ...     ILaunchpadCelebrities)
> +    >>> pofile = factory.makePOFile('ru')
> +    >>> rosetta_experts = getUtility(ILaunchpadCelebrities).rosetta_experts
> +    >>> message = factory.makeTranslationMessage(
> +    ...     pofile=pofile, translator=rosetta_experts, translations=['x'])
> +    >>> logout()
> +
> +    >>> carlos_browser = setupBrowser('Basic <email address hidden>:test')
> +    >>> experts_home = 'http://translations.launchpad.dev/~rosetta-admins'
> +    >>> carlos_browser.open(experts_home)
> +
> +    >>> print extract_text(find_tag_by_id(
> +    ...     jean_browser.contents, 'translations-to-complete-table'))
> 
> === modified file 'lib/lp/translations/tests/test_pofile.py'
> --- lib/lp/translations/tests/test_pofile.py	2009-10-30 10:29:25 +0000
> +++ lib/lp/translations/tests/test_pofile.py	2009-11-26 10:47:06 +0000
> @@ -911,6 +911,7 @@
>          self.assertNotEqual(None, stable_potemplate.getPOFileByLang('eo'))
>          self.assertNotEqual(None, stable_potemplate.getPOFileByLang('de'))
>  
> +
>  class TestTranslationCredits(TestCaseWithFactory):
>      """Test generation of translation credits."""
>  
> 
> === modified file 'lib/lp/translations/tests/test_potmsgset.py'
> --- lib/lp/translations/tests/test_potmsgset.py	2009-11-11 11:38:22 +0000
> +++ lib/lp/translations/tests/test_potmsgset.py	2009-11-26 10:47:06 +0000
> @@ -15,6 +15,7 @@
>  from zope.security.proxy import isinstance as zope_isinstance
>  from zope.security.proxy import removeSecurityProxy
>  
> +from canonical.launchpad.interfaces.launchpad import ILaunchpadCelebrities
>  from lp.registry.interfaces.person import IPersonSet
>  from lp.registry.interfaces.product import IProductSet
>  from lp.services.worlddata.interfaces.language import ILanguageSet
> @@ -23,7 +24,6 @@
>  from lp.translations.interfaces.translationfileformat import (
>      TranslationFileFormat)
>  from lp.translations.interfaces.translationmessage import TranslationConflict
> -from lp.translations.interfaces.translationsperson import ITranslationsPerson
>  from lp.translations.model.translationmessage import (
>      DummyTranslationMessage)
>  
> @@ -675,41 +675,20 @@
>          self.assertNotEqual(None, current_shared)
>          self.assertEqual(None, current_shared.potemplate)
>  
> -    def test_setTranslationCreditsToTranslated_permissions(self):
> -        # Even if POFile.owner has not agreed to the Launchpad
> -        # translations licensing policy, automated credit
> -        # messages are still created.
> -        sr_pofile = self.factory.makePOFile('sr', self.devel_potemplate)
> -        owner = sr_pofile.owner
> -        ITranslationsPerson(owner).translations_relicensing_agreement = False
> -        credits_potmsgset = self.factory.makePOTMsgSet(
> -            self.devel_potemplate, singular=u'translator-credits')
> -        current = credits_potmsgset.getCurrentTranslationMessage(
> -            self.devel_potemplate, sr_pofile.language)
> -        self.assertEqual(owner, current.submitter)
> -
> -    def test_setTranslationCreditsToTranslated_submitter_lasttranslator(self):
> -        # Submitter on the automated translation message is set to
> -        # POFile.lasttranslator if it's defined.
> -        sr_pofile = self.factory.makePOFile('sr', self.devel_potemplate)
> -        last_translator = self.factory.makePerson()
> -        sr_pofile.lasttranslator = last_translator
> -        credits_potmsgset = self.factory.makePOTMsgSet(
> -            self.devel_potemplate, singular=u'translator-credits')
> -        current = credits_potmsgset.getCurrentTranslationMessage(
> -            self.devel_potemplate, sr_pofile.language)
> -        self.assertEqual(last_translator, current.submitter)
> -
> -    def test_setTranslationCreditsToTranslated_submitter_owner(self):
> -        # Submitter on the automated translation message is set to
> -        # POFile.owner if POFile.lasttranslator is not defined.
> -        sr_pofile = self.factory.makePOFile('sr', self.devel_potemplate)
> -        self.assertEqual(None, sr_pofile.lasttranslator)
> -        credits_potmsgset = self.factory.makePOTMsgSet(
> -            self.devel_potemplate, singular=u'translator-credits')
> -        current = credits_potmsgset.getCurrentTranslationMessage(
> -            self.devel_potemplate, sr_pofile.language)
> -        self.assertEqual(sr_pofile.owner, current.submitter)
> +    def test_setTranslationCreditsToTranslated_submitter(self):
> +        # Submitter on the automated translation message is always
> +        # the rosetta_experts team.
> +        sr_pofile = self.factory.makePOFile('sr', self.devel_potemplate)
> +        translator = self.factory.makePerson()
> +        sr_pofile.lasttranslator = translator
> +        sr_pofile.owner = translator
> +        credits_potmsgset = self.factory.makePOTMsgSet(
> +            self.devel_potemplate, singular=u'translator-credits')
> +        current = credits_potmsgset.getCurrentTranslationMessage(
> +            self.devel_potemplate, sr_pofile.language)
> +
> +        rosetta_experts = getUtility(ILaunchpadCelebrities).rosetta_experts
> +        self.assertEqual(rosetta_experts, current.submitter)
>  
>  
>  class TestPOTMsgSetSuggestions(TestCaseWithFactory):
>