Merge lp:~jtv/launchpad/bug-615673 into lp:launchpad
Proposed by
Jeroen T. Vermeulen
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Graham Binns | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11432 | ||||
| Proposed branch: | lp:~jtv/launchpad/bug-615673 | ||||
| Merge into: | lp:launchpad | ||||
| Diff against target: |
25 lines (+2/-2) 2 files modified
lib/lp/translations/interfaces/potemplate.py (+1/-1) lib/lp/translations/model/potemplate.py (+1/-1) |
||||
| To merge this branch: | bzr merge lp:~jtv/launchpad/bug-615673 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Make POTemplate.path required.
Description of the change
= Bug 615673 =
For some reason, POTemplate.path and IPOTemplate.path are marked as not required. That's nonsense. POTemplates are always created with a path. There is a database constraint requiring the path. Even the parameter to the factory method is required. Everything assumes it's there.
Here's a branch I never spent any time on; I just made the field required and sent the whole thing off to EC2. It just got back to me to say that the change is no problem at all. Might as well make it permanent.
To test, er, run all tests. That's what I did. And to Q/A, see that nothing breaks. If something does, chances are it's still a bug that this was just covering up for.
Jeroen
To post a comment you must log in.
Revision history for this message
| Graham Binns (gmb) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
