Merge lp:~jtv/launchpad/db-bug-476218 into lp:launchpad/db-devel
Proposed by
Jeroen T. Vermeulen
| Status: | Merged |
|---|---|
| Approved by: | Jeroen T. Vermeulen |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp:~jtv/launchpad/db-bug-476218 |
| Merge into: | lp:launchpad/db-devel |
| Diff against target: |
12 lines (+5/-0) 1 file modified
lib/lp/translations/doc/fix_translation_credits.txt (+5/-0) |
| To merge this branch: | bzr merge lp:~jtv/launchpad/db-bug-476218 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Nelson (community) | release-critical | Approve | |
| Abel Deuring (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Fix buildbot breakage: test failed to force a dirty db.
To post a comment you must log in.
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | # |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | # |
review:
Approve
(release-critical)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
= Bug 476218 =
Buildbot was breaking on a test gettext-
had touched. A POTranslation it created used an id that was already
taken. As Michael Nelson found out, this happened only when the test
ran in conjunction with fix_translation
The problem was that that latter test runs a script, which updates the
database, but doesn't do anything to tell the test framework that there
have been any database changes. So the database did not get a full
reset.
This hints at another bug somewhere: the id sequences normally get reset
to one beyond the highest id currently represented in the table. It
follows that this problem should not have happened, at least not as I
described. So either my description is wrong, or there is another
problem with the way ids get reset.
We'll still have to look into that, but this fix unbreaks the tests.
Jeroen