Launchpad itself

Merge ~jugmac00/launchpad:fix-bad-umask-error into launchpad:master

Proposed by Jürgen Gmach on 2024-02-16

Status:	Merged
Approved by:	Jürgen Gmach on 2024-02-16
Approved revision:	c664baad7cbcda7032572240b763df0bb1e46c79
Merge reported by:	Otto Co-Pilot
Merged at revision:	not available
Proposed branch:	~jugmac00/launchpad:fix-bad-umask-error
Merge into:	launchpad:master
Diff against target:	13 lines (+1/-1) 1 file modified charm/launchpad-copy-archive-publisher/templates/crontab.j2 (+1/-1)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Simone Pelosi		2024-02-16	Approve on 2024-02-16
Review via email: mp+460664@code.launchpad.net

Fix missing umask call

A previous attempt to fix this issue was applied to a script where umask was also missing, but that did not fix the issue.

Revision history for this message

Simone Pelosi (pelpsi) wrote on 2024-02-16:

LGTM!

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

to status/vote changes:

1	diff --git a/charm/launchpad-copy-archive-publisher/templates/crontab.j2 b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
2	index bf2502b..4b7e7d4 100644
3	--- a/charm/launchpad-copy-archive-publisher/templates/crontab.j2
4	+++ b/charm/launchpad-copy-archive-publisher/templates/crontab.j2
5	@@ -8,7 +8,7 @@ LPCONFIG=launchpad-copy-archive-publisher
6
7	10 /6 * * {{ code_dir }}/scripts/process-death-row.py --all-derived -q --log-file=DEBUG:{{ logs_dir }}/derived-process-death-row.log
8
9	-22 * * * * {{ base_dir }}/bin/cron.publish-copy-archives.sh >> {{ logs_dir }}/cron.publish-copy-archives.log 2>&1
10	+22 * * * * umask 022; {{ base_dir }}/bin/cron.publish-copy-archives.sh >> {{ logs_dir }}/cron.publish-copy-archives.log 2>&1
11
12	15 * * * * nice -n 12 ionice -c 2 -n 7 {{ code_dir }}/cronscripts/ppa-generate-keys.py --copy-archives -q --log-file=INFO:{{ logs_dir }}/generate-keys-copy-archives.log
13	{%- endif %}