~jugmac00/launchpad:add-more-context-to-MP-diff-previews

Branch merges

Propose for merging

On hold for merging into launchpad:master

Launchpad code reviewers: Pending requested 2023-08-07

Diff: 130 lines (+70/-2)

4 files modified

lib/lp/code/browser/branchmergeproposal.py (+1/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+66/-0)
lib/lp/code/model/diff.py (+2/-2)
lib/lp/code/model/tests/test_diff.py (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

e66cb92... by Jürgen Gmach on 2023-08-08

[WIP] Add more context to MP diff previews

todos:
- figure out format for the links to the source file
- add links to the expected output
- add implementation (possibly regex based)

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

65b780b... by Jürgen Gmach on 2023-08-07

Mark bazaar and git part of factory

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

bf9286d... by Jürgen Gmach on 2023-08-04

Fix typos in stringformatter.py

Merged from https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/448510

2192947... by Jürgen Gmach on 2023-08-04

Fix typos in stringformatter.py

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

422d70b... by Colin Watson on 2023-08-04

Commit after running SET ROLE

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/448506

5360674... by Jürgen Gmach on 2023-08-04

Improve docstrings in the run-parts module

Merged from https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/448090

43c8d5f... by Peter Makowski on 2023-08-04

update Ubuntu Mono variable font
- add Ubuntu variable font

Merged from https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/447969

be26983... by Colin Watson on 2023-08-04

Commit after running SET ROLE

In charmed deployments configured with `set_role_after_connecting:
True`, we execute a `SET ROLE` command immediately after connecting to
the database. However, according to
https://www.postgresql.org/docs/10/sql-set.html which is referenced by
https://www.postgresql.org/docs/10/sql-set-role.html, the effects of the
`SET` command disappear if the transaction is rolled back. We must
therefore commit the transaction to ensure that the effects persist
until the end of the session.

I strongly suspect that this is why we've been seeing `buildd-manager`
sometimes running as the wrong database role: it's to be expected that
Launchpad code will roll back transactions sometimes, for example as
part of handling an exception, and if that happened to be one of the
first things that `buildd-manager` did then we'd see this effect.

539bd1d... by Colin Watson on 2023-08-04

charm: Fix final part name

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/448498

a53ab5b... by Guruprasad on 2023-08-04

charm/launchpad-scripts-bzrsyncd: Add missing config to the celerybeat service

Merged from https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/448475