lp:~kamstrup/zeitgeist/notification

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:zeitgeist/0.1

Mikkel Kamstrup Erlandsen: Approve on 2009-12-05

Markus Korn: Needs Fixing on 2009-12-03

Markus Korn: Pending (thorough) requested 2009-12-02

Diff: 1018 lines (+760/-29)

9 files modified

_zeitgeist/engine/Makefile.am (+1/-0)
_zeitgeist/engine/notify.py (+261/-0)
_zeitgeist/engine/remote.py (+49/-19)
_zeitgeist/engine/resonance_engine.py (+10/-0)
doc/dbus/source/index.rst (+6/-0)
test/datamodel-test.py (+44/-2)
test/remote-test.py (+64/-0)
zeitgeist/client.py (+225/-4)
zeitgeist/datamodel.py (+100/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #488967: Add event notification and subscription system

High

Fix Released

Link a bug report

Related blueprints

1214. By Mikkel Kamstrup Erlandsen on 2009-12-05

Allow an empty set of Monitor templates to match anything

1213. By Mikkel Kamstrup Erlandsen on 2009-12-05

Whopping commit updating the Monitor/Notify framework as follows:

org.gnome.zeitgeist.Monitor now has two methods:

  NotifyInsert(in (xx) time_range, in aE events)
  NotifyDelete(in (xx) time_range, in au event_ids)

The client.install_monitor() method needed to be adapted to take two callbacks instad
The NotifyDelete call always receives _all_ deleted event ids. We can however at times
drop the notification all together if the Monitor time range is outside of the time range
of the deleted events.

The core notification system, notify.py needed update to this new DBus signature

I also changed delete_events() in resonance_engine.py to return the max and min
timestamps for the affectedd events.

Add some convenience constructors to TimeRange. Namely .always() and .from_now().

1212. By Mikkel Kamstrup Erlandsen on 2009-12-04

Implement some convenience methods regarding time ranges:

TimeRange.intersect(time_range) - calculates the intersection TimeRange of self and time_range

Event.in_time_range(time_range) - returns True if event.timestamp lies in time_range

1211. By Mikkel Kamstrup Erlandsen on 2009-12-03

Comments and doc updates

1210. By Mikkel Kamstrup Erlandsen on 2009-12-03

Change DBus API for the Monitor.Notify() method to take an uint32 as first argument.
This first arg is an enumeration: NotifyInsert=0 and NotifyDelete=1 designating
the type of notification.

Still delete notifications remains to be handled. I wrote in the docs that we only
return the event ids in the event structs on NotifyDelete

1209. By Mikkel Kamstrup Erlandsen on 2009-12-03

Fix insertion/removal of monitors in notify.py. The attached test case exposes a bug where we must use the monitor hash as key instead of simply the monitor itself

1208. By Mikkel Kamstrup Erlandsen on 2009-12-03

Fix signature of the dispath_handler() in client.remove_monitor()

Also fix a warning statement

1207. By Mikkel Kamstrup Erlandsen on 2009-12-03

Fix type in debug string

1206. By Mikkel Kamstrup Erlandsen on 2009-12-03

Add a monitor_removed_handler arg to remove_monitor()

1205. By Mikkel Kamstrup Erlandsen on 2009-12-03

Add some clarifying comments in the install_monitor()

Fix debug statement in remove_monitor()