Merge lp:~karni/ubuntuone-android-music/playlist-caching into lp:ubuntuone-android-music
Proposed by
Michał Karnicki
| Status: | Merged |
|---|---|
| Merged at revision: | 567 |
| Proposed branch: | lp:~karni/ubuntuone-android-music/playlist-caching |
| Merge into: | lp:ubuntuone-android-music |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~karni/ubuntuone-android-music/playlist-caching |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Miller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch adds playlist prefetching and caching.
Some small part of the lines has not been changed by me, but the indentation has been corrected from tabs to spaces. *Feels really bad about indentation with spaces :/*
To post a comment you must log in.
176 + } catch (Exception e) {
177 + Log.d(TAG, "There is no usable cache of playlists.");
178 + }
That Exception seems overly broad, especially if we're going to log it at such a low level and then discard the exception without logging what it was.
250 + Playlist playlist = (Playlist) parent.
I'll bet we'll see ArrayIndexOutOf