Merge lp:~ken-vandine/gwibber/expander into lp:gwibber
Proposed by
Ken VanDine
| Status: | Merged |
|---|---|
| Merged at revision: | 1247 |
| Proposed branch: | lp:~ken-vandine/gwibber/expander |
| Merge into: | lp:gwibber |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~ken-vandine/gwibber/expander |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Puts comments and image previews inside a Gtk.Expander
* This prevents the constant tile resizing while scrolling
* Only loads images when expanded, which prevents the async loading while scrolling
Fixed a nasty memory leak in ActionBoxItem
* With the leak fixed I also removed a bunch of hacks which iterated over child widgets and destroyed them. It only partially fixed the problem, and not effectively.
To test the fix:
* Verify scrolling doesn't cause a significant increase in memory usage.
* While scrolling you shouldn't see a noticable tile resize on scroll
To post a comment you must log in.
Looks good!