Merge lp:~ki7mt/ubuntu-docs/accounts-files-patch into lp:ubuntu-docs/trusty

When I compare the proposed new "Online Accounts" page with the old one (basically with the 13.10 one), it is not clear to me why "Create an Online Account" and "Control Which online services an account can be be used to access" were deleted from that page.

For lines 129 and 130 below, shouldn't there be a couple of commas? (but note, I am an engineer and not an English major) I.E.

You can enter your login details for online services, like Google and
Facebook, into the <app>Online Accounts</app> window.

For "Add an Account" this sentence is odd:

    After you have added the accounts, each application you have selected will
                automatically use those credentials when you log into your account them.

I think the "them" at the end is somehow left over. (and might have been in yesterdays MP, as in the end I am looking both together).

I'm not done reviewing yet, but am saving this comment for now. More later.

Again, for the "Add an Account" page:
. I like the blue circle with the "i" in it (the original) better than the yellow box with a pin in it (proposed) for the security reasons note.
. Note sure I would have made the second line of what is now item 3 a yellow pinned note. Wasn't it good enough before? (in the end I don't really care).

Under "Remove an Account" note added to item 4. Please change "now" to "no".

O.K. now I see the copyright notice talked about on IRC. Yes, in my opinion that is wrong and needs to be deleted.

Under "Why is my account type not on the list?" I like the original page better, but in the end I don't really care.

Note: I haven't built or looked at the html yet.

On Sat, 2014-01-11 at 00:03 +0000, Doug Smythies wrote:
> When I compare the proposed new "Online Accounts" page with the old one
> (basically with the 13.10 one), it is not clear to me why "Create an Online Account">
> and "Control Which online services an account can be be used to access" were deleted
> from that page.

-----
Create online account and Add an Account were duplicate files:
- accounts-create.page
- accounts-add.page

I picked one to use, accounts-add.page as I felt "Create an Online Account" was a bit
misleading, in so far as, it would lead the user to belive they could or should use the
Online Accounts apps to create their service account, e.g. Google, Yahoo, AIM etc.
-----

> For lines 129 and 130 below, shouldn't there be a couple of commas? (but note, I am an
> engineer and not an English major) I.E.
>
> You can enter your login details for online services, like Google and
> Facebook, into the <app>Online Accounts</app> window.

-----
A simple fox for this would be to put the ( ) back in: (like Google and
Facebook). But I believe I also changed Window to application for
clarity.

I've updated the MP and will push the changes when the remaining itmes
are are resolved.
-----

> For "Add an Account" this sentence is odd:
>
> After you have added the accounts, each application you have selected will
> automatically use those credentials when you log into your account them.

-----
This is fixed for the MP update:

"You can enter your login details for online services (like Google and
Facebook) into the <app>Online Accounts</app> application. This will let
you access your calendar, mail, chat accounts, and similar applications
without having to enter your account details again."
-----

> I think the "them" at the end is somehow left over. (and might have been in
> yesterdays MP, as in the end I am looking both together).
>
> I'm not done reviewing yet, but am saving this comment for now. More later.
>
> Again, for the "Add an Account" page:
> . I like the blue circle with the "i" in it (the original) better than the yellow
> box with a pin in it (proposed) for the security reasons note.
> Note sure I would have made the second line of what is now item
> 3 a yellow pinned note. Wasn't it good enough before? (in the end I don't really care).

-----
This is fixed for the MP update:
I changed them back to <note style="tip">
-----

On Sat, 2014-01-11 at 00:20 +0000, Doug Smythies wrote:
> Review: Needs Fixing
>
> Under "Remove an Account" note added to item 4. Please change "now" to "no".
>

-----
This is fixed for the MP update:
fixed now to no
also fixed "providor to "provider"
-----

> O.K. now I see the copyright notice talked about on IRC. Yes, in my opinion
> that is wrong and needs to be deleted. Under "Why is my account type not on
> the list?" I like the original page better, but in the end I don't really care.

-----
As noted in my submit logs, I'm not fond of either page, but saw no
reason to have long list of single point <item> tags.
-----

> Note: I haven't built or looked at the html yet.

-----
I've not built 13.10 for comparison. Im using the Help Doc currently in
14.04 which was probably pulled form 13.10, not sure.

But allot of the changes made make sense when viewing the HTML.
----

bzr reported a conflict in accounts.page when I tried to "pull" the updated MP. I made an additional change while resolving the conflict, and am now proposing this:

  <p>
    You can enter your login details for online services, such as Google and
    Facebook, into the <app>Online Accounts</app> application. This will let you
    access your calendar, mail, chat accounts, and similar applications without
                having to enter your account details again.
  </p>

Also, we need to agree if increased deviation between GNOME help and unity help is the way forward. I'll make an e-mail with screen shots, and send it to KI7MT and desktop help active doc committers to try to assist in explaining. That e-mail will not be sent for at least several hours from now.