Launchpad itself

Merge lp:~kirkland/launchpad/532624 into lp:launchpad

  1. 532624
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Approved by: Deryck Hodge
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~kirkland/launchpad/532624
Merge into: lp:launchpad
Diff against target: 25 lines (+2/-2)
2 files modified
lib/lp/registry/browser/person.py (+1/-1)
lib/lp/registry/stories/person/xx-person-bugs.txt (+1/-1)
To merge this branch: bzr merge lp:~kirkland/launchpad/532624
Reviewer Review Type Date Requested Status
Curtis Hovey (community) ui Approve
Deryck Hodge (community) code Approve
Review via email: mp+20775@code.launchpad.net

Commit message

Change the person bugs page link of "show package report" to the more intuitive "list subscribed packages."

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

The code is simple and looks good. Thanks for fixing an affected test, too. I'll run this through ec2 just to make sure all tests are covered.

You'll also need to get a UI reviewer to approve the change. Ping noodles775 or sinzui in #launchpad-reviews on Freenode for this.

Thanks again for fixing this!

Cheers,
deryck

review: Approve (code)
Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Dustin.

Do you want me to ping a UI reviewer for this for you? Or would you like to follow up with them about UI review. It's a minor change, I realize, but still it would be nice to get a UI reviewer ack on this.

Cheers,
deryck

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

On Fri, Mar 19, 2010 at 6:41 AM, Deryck Hodge
<email address hidden> wrote:
> Do you want me to ping a UI reviewer for this for you?  Or would you like to follow up with them about UI review.  It's a
> minor change, I realize, but still it would be nice to get a UI reviewer ack on this.

Hi Deryck-

It's a trivial bug, with a patch, and a branch, and a merge proposal.
  Honestly, I'd think that my job as a drive by community contributor
should be over at this point (bug filed, source branched, fixed, merge
proposed).

Ideally, you guys (Launchpad, UI, whoever), take it upstream, and roll
it out in a future release.

I don't really have the time or inclination to drive it further than this.

:-Dustin

Revision history for this message
Deryck Hodge (deryck) wrote :

Different people have different expectations about how long they want to stick with a branch to see it landed, which is why I asked.

I'll take it from here. Thanks for the patch.

Cheers,
deryck

Revision history for this message
Curtis Hovey (sinzui) :
review: Approve (ui)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/browser/person.py'
2--- lib/lp/registry/browser/person.py 2010-03-05 14:18:18 +0000
3+++ lib/lp/registry/browser/person.py 2010-03-05 19:25:28 +0000
4@@ -754,7 +754,7 @@
5 return Link('+assignedbugs', text, site='bugs', summary=summary)
6
7 def softwarebugs(self):
8- text = 'Show package report'
9+ text = 'List subscribed packages'
10 summary = (
11 'A summary report for packages where %s is a bug supervisor.'
12 % self.context.displayname)
13
14=== modified file 'lib/lp/registry/stories/person/xx-person-bugs.txt'
15--- lib/lp/registry/stories/person/xx-person-bugs.txt 2010-02-10 12:14:41 +0000
16+++ lib/lp/registry/stories/person/xx-person-bugs.txt 2010-03-05 19:25:28 +0000
17@@ -159,7 +159,7 @@
18 http://bugs.launchpad.dev/~name12/+subscribedbugs
19 >>> print anon_browser.getLink('List all related bugs').url
20 http://bugs.launchpad.dev/~name12
21- >>> print anon_browser.getLink('Show package report').url
22+ >>> print anon_browser.getLink('List subscribed packages').url
23 http://bugs.launchpad.dev/~name12/+packagebugs
24 >>> anon_browser.open('http://launchpad.dev/~name12/+commentedbugs')
25 >>> print anon_browser.getLink('List assigned bugs').url