GTG

Merge lp:~kjmikkel/gtg/hideToolbar into lp:~gtg/gtg/old-trunk

  1. hideToolbar
  2. Merge into old-trunk
Proposed by silentStatic
Status: Merged
Merged at revision: not available
Proposed branch: lp:~kjmikkel/gtg/hideToolbar
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 31 lines
3 files modified
AUTHORS (+1/-0)
CHANGELOG (+1/-0)
GTG/taskbrowser/browser.py (+2/-0)
To merge this branch: bzr merge lp:~kjmikkel/gtg/hideToolbar
Reviewer Review Type Date Requested Status
Lionel Dricot (community) Needs Fixing
Review via email: mp+12497@code.launchpad.net
To post a comment you must log in.
Revision history for this message
silentStatic (kjmikkel) wrote :

Purpose:
To make it possible to hide the toolbar, like all the rest of the UI elements mentioned in the View window

Fix:
The function was not referenced in the SIGNAL_CONNECTIONS_DIC dictionary - the function itself has not been modified.

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

Some bzr stuffs left in the CHANGELOG. Could you fix that ?

review: Needs Fixing
lp:~kjmikkel/gtg/hideToolbar updated
325. By Mikkel Kjær Jensen <mikkel@mikkel-laptop>

Trying to get rid of bzr stuff

326. By Mikkel Kjær Jensen <mikkel@mikkel-laptop>

Trying again

327. By Mikkel Kjær Jensen <mikkel@mikkel-laptop>

attempt merge

328. By Mikkel Kjær Jensen <mikkel@mikkel-laptop>

After merge

329. By Mikkel Kjær Jensen <mikkel@mikkel-laptop>

Meged correctly this time

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2009-09-11 22:58:12 +0000
3+++ AUTHORS 2009-09-28 12:24:14 +0000
4@@ -37,3 +37,4 @@
5 * Paulo Cabido <paulo.cabido@gmail.com>
6 * Patrick Coleman <blinken@gmail.com>
7 * Luca Invernizzi <invernizzi.l@gmail.com>
8+* Mikkel Kjær Jensen <kjmikkel@gmail.com>
9\ No newline at end of file
10
11=== modified file 'CHANGELOG'
12--- CHANGELOG 2009-09-25 16:22:02 +0000
13+++ CHANGELOG 2009-09-28 12:24:14 +0000
14@@ -1,3 +1,4 @@
15+ * The toolbar can now be hidden by Mikkel Kjær Jensen
16 * Empty new tasks are deleted when editor is closed
17 * lot of bug fixed in the editor while playing with subtasks
18 * Works well with the "text besides icon" GNOME option
19
20=== modified file 'GTG/taskbrowser/browser.py'
21--- GTG/taskbrowser/browser.py 2009-09-25 16:22:02 +0000
22+++ GTG/taskbrowser/browser.py 2009-09-28 12:24:14 +0000
23@@ -309,6 +309,8 @@
24 self.on_quickadd_activate,
25 "on_view_quickadd_toggled":
26 self.on_toggle_quickadd,
27+ "on_view_toolbar_toggled":
28+ self.on_toolbar_toggled,
29 "on_about_clicked":
30 self.on_about_clicked,
31 "on_about_close":

Subscribers

People subscribed via source and target branches

to status/vote changes: