Ubuntu Documentation

Merge lp:~kotux/ubuntu-docs/improved-lowpower into lp:ubuntu-docs/saucy

  1. improved-lowpower
  2. Merge into saucy
Proposed by John Kim
Status: Superseded
Proposed branch: lp:~kotux/ubuntu-docs/improved-lowpower
Merge into: lp:ubuntu-docs/saucy
Diff against target: 20 lines (+5/-5)
1 file modified
ubuntu-help/C/power-lowpower.page (+5/-5)
To merge this branch: bzr merge lp:~kotux/ubuntu-docs/improved-lowpower
Reviewer Review Type Date Requested Status
Benjamin Kerensa (community) Needs Information
Review via email: mp+169099@code.launchpad.net

Description of the change

Just added some clarity to a paragraph on power-lowpower.page. LP #1189282

To post a comment you must log in.
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

Looks good to me. I will have Kevin Godby add input and if he +1's he can merge it in.

Revision history for this message
Doug Smythies (dsmythies) wrote :

Hi Guys. Please hold on this one for a bit.

It is not clear to me that the root issue here is not yet another manifestation of the new theme not displaying with differentiation properly (i.e within the <gui>...</gui> tags).
This could be just like bug 1173426.

My problem is that I did not keep a backup copy of the stuff in the old theme, after the recent EOL for some versions. It will take me some time to figure out how to get some old theme stuff from launchpad to compare, and then be able to comment further.

Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

On hold pending more from Doug.

review: Needs Information
Revision history for this message
Doug Smythies (dsmythies) wrote :

O.K. I have made notes and added attachments (screen shots) to the bug 1189282.
I also added notes and the same screen shots to bug 1173426.

I think the root issue is lack of display differentiation within some tags pairs. I submit that it is the root issue we should pursue here, and therefore this merge proposal should be rejected. I'll post this as a comment only, as I seek agreement and/or debate from the others.

Revision history for this message
John Kim (kotux) wrote :

Although I intended to make a grammar fix, Doug is right in that the gui tags should be noticeable because it wasn't. However, I believe that such an issue can be made and fixed for another report, unless this paragraph revision wasn't necessary.

Revision history for this message
Doug Smythies (dsmythies) wrote :

John, I guess I was focusing on the portion of the change where this:

<gui>When power is critically low</gui>

changes to this:

<gui>'When power is critically low'</gui>

And I am suggesting, that if the compiler formatted it properly the quotes wouldn't be needed.
Otherwise, I have no opinion either way on this one.

Revision history for this message
John Kim (kotux) wrote :

Ok. Once the root issue is resolved, we can then consider merging this sort of branch.

Revision history for this message
Doug Smythies (dsmythies) wrote :

Can and end be put to this one?

The preliminary 13.10 desktop docs (English only for now)have been posted so see also:

https://help.ubuntu.com/13.10/ubuntu-help/power-lowpower.html

Unmerged revisions

217. By John Kim

Improved a paragraph in power-lowpower. LP #1189282

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/power-lowpower.page'
2--- ubuntu-help/C/power-lowpower.page 2012-09-20 16:30:39 +0000
3+++ ubuntu-help/C/power-lowpower.page 2013-06-13 03:31:28 +0000
4@@ -27,11 +27,11 @@
5 the battery. If the battery just ran out, the computer wouldn't have time to
6 shut down properly either.</p>
7
8-<p>You can change what happens when the battery level gets too low by clicking
9- the <gui>battery menu</gui> in the <gui>menu bar</gui> and selecting <gui>Power Settings</gui>. Look at the <gui>When
10-power is critically low</gui> setting. You can choose for the computer to
11-suspend, <link xref="power-hibernate">hibernate</link> or shut down. If you choose shut down, your applications and
12-documents <em>will not</em> be saved before the computer turns off.</p>
13+<p>You can change what happens when the battery level gets too low. First, click the
14+<gui>battery menu</gui> in the <gui>menu bar</gui> and select <gui>Power Settings</gui>. At the <gui>'When
15+power is critically low'</gui> setting, you can choose for the computer to
16+suspend, <link xref="power-hibernate">hibernate</link>, or shut down. If you choose shut down, your applications and
17+documents <em>will not</em> be saved when the computer turns off.</p>
18
19 <p>Some computers have problems suspending, and may not be able to recover the
20 applications and documents you had open when you turn on the computer again. In

Subscribers

People subscribed via source and target branches