Merge launchpad-mojo-specs:increase-proxy-token_ttl_minutes into launchpad-mojo-specs:master
Proposed by
Ines Almeida
| Status: | Needs review |
|---|---|
| Proposed branch: | launchpad-mojo-specs:increase-proxy-token_ttl_minutes |
| Merge into: | launchpad-mojo-specs:master |
| Diff against target: |
13 lines (+1/-1) 1 file modified
lp-builder-proxy/bundle.yaml (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Clinton Fung | Approve | ||
| Jürgen Gmach | Approve | ||
| William Grant | Pending | ||
|
Review via email:
|
|||
Commit message
Increase the builder proxy's token_ttl_minutes from 6 hours to 18 hours
Description of the change
Builds have been failing due to our current 6 hour token timeout, particularly riscv builds.
There is no particular reason for having 6 hours, as long as the number is sensible.
In a chat with the team, 18 hours was discussed as a possibility.
To post a comment you must log in.
Revision history for this message
| Clinton Fung (clinton-fung) | # |
review:
Approve
Unmerged commits
- f1080fa... by Ines Almeida
-
lint:0 (build) 1 → 1 of 1 result First • Previous • Next • Last
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Could you add a comment above the updated line which explains the magic number? I know that we can use git to look up the commit message, but those might be harder to access when things get changed, reformatted or similar. Thank you!