Launchpad itself

Merge ~lgp171188/launchpad:update-haproxy-relations-when-config-changes into launchpad:master

  1. Git
  2. lp:~lgp171188/launchpad
  3. update-haproxy-relations-when-config-changes
  4. Merge into master
Proposed by Guruprasad
Status: Merged
Approved by: Guruprasad
Approved revision: 8a2ed14fcdc4fd9953cd3daaae5f9e98426db83f
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~lgp171188/launchpad:update-haproxy-relations-when-config-changes
Merge into: launchpad:master
Diff against target: 39 lines (+24/-0)
1 file modified
charm/launchpad-codehosting/reactive/launchpad-codehosting.py (+24/-0)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Ines Almeida Approve
Review via email: mp+458148@code.launchpad.net

Commit message

charm/launchpad-codehosting: Reconfigure haproxy relations on config changes

When a configuration variable used by an haproxy relation changes,
reconfigure that relation to apply the change.

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

Makes sense

review: Approve
Revision history for this message
Guruprasad (lgp171188) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
2index b8eb323..f8cd61f 100644
3--- a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
4+++ b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
5@@ -429,6 +429,21 @@ def configure_frontend_loadbalancer():
6 set_state("launchpad-codehosting.frontend-loadbalancer.configured")
7
8
9+@when(
10+ "config.changed.haproxy_service_options_http",
11+ "config.changed.haproxy_service_options_https",
12+ "config.changed.haproxy_service_options_ssh",
13+ "config.changed.haproxy_fe_server_options",
14+ "config.changed.haproxy_fe_server_options_ssh",
15+ "config.changed.port_lb_bzr_sftp",
16+ "config.changed.port_bzr_sftp_base",
17+ "config.changed.port_web_status_base",
18+ "config.changed.workers",
19+)
20+def deconfigure_frontend_loadbalancer():
21+ clear_flag("launchpad-codehosting.frontend-loadbalancer.configured")
22+
23+
24 @when("loadbalancer.available", "service.configured")
25 @when_not("launchpad-codehosting.loadbalancer.configured")
26 def configure_loadbalancer():
27@@ -471,3 +486,12 @@ def configure_loadbalancer():
28 hookenv.relation_set(rel["__relid__"], services=services_yaml)
29
30 set_state("launchpad-codehosting.loadbalancer.configured")
31+
32+
33+@when(
34+ "config.changed.haproxy_service_options_internal_branch_by_id",
35+ "config.changed.haproxy_server_options",
36+ "config.changed.port_bzr_internal",
37+)
38+def deconfigure_loadbalancer():
39+ clear_flag("launchpad-codehosting.loadbalancer.configured")

Subscribers

People subscribed via source and target branches

to status/vote changes: