Launchpad itself

Merge ~lgp171188/launchpad:charm-launchpad-codehosting-fix-double-slash-rewrite-url into launchpad:master

Proposed by Guruprasad on 2024-05-03

Status:	Merged
Approved by:	Guruprasad on 2024-05-06
Approved revision:	8ed40732bc7ebdc98b37f5a620beb368bb035502
Merge reported by:	Otto Co-Pilot
Merged at revision:	not available
Proposed branch:	~lgp171188/launchpad:charm-launchpad-codehosting-fix-double-slash-rewrite-url
Merge into:	launchpad:master
Diff against target:	11 lines (+1/-1) 1 file modified charm/launchpad-codehosting/templates/vhosts/bazaar_https.conf.j2 (+1/-1)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Simone Pelosi		2024-05-03	Approve on 2024-05-03
Review via email: mp+465505@code.launchpad.net

charm/launchpad-codehosting: Fix a double slash in an apache2 rewrite rule

Revision history for this message

Simone Pelosi (pelpsi) wrote on 2024-05-03:

LGTM!

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

to status/vote changes:

1	diff --git a/charm/launchpad-codehosting/templates/vhosts/bazaar_https.conf.j2 b/charm/launchpad-codehosting/templates/vhosts/bazaar_https.conf.j2
2	index 2740a53..deb320d 100644
3	--- a/charm/launchpad-codehosting/templates/vhosts/bazaar_https.conf.j2
4	+++ b/charm/launchpad-codehosting/templates/vhosts/bazaar_https.conf.j2
5	@@ -33,6 +33,6 @@
6	RewriteRule ^/robots.txt$ - [L]
7	RewriteRule ^/favicon.ico$ {{ loggerhead_static_dir }}/images/favicon.ico [L]
8	RewriteRule ^/static/(.*)$ /$1 [L]
9	- RewriteRule ^/(.*)$ {{ internal_codebrowse_root }}/$1 [P,L]
10	+ RewriteRule ^/(.*)$ {{ internal_codebrowse_root }}$1 [P,L]
11	</VirtualHost>
12