Merge lp:~lifeless/bzr/bug-558343-wrong-host-with-proxy into lp:bzr
Proposed by
Robert Collins
Status: | Merged |
---|---|
Approved by: | Vincent Ladeuil |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5220 |
Proposed branch: | lp:~lifeless/bzr/bug-558343-wrong-host-with-proxy |
Merge into: | lp:bzr |
Diff against target: |
70 lines (+19/-13) 2 files modified
NEWS (+3/-0) bzrlib/transport/http/_urllib2_wrappers.py (+16/-13) |
To merge this branch: | bzr merge lp:~lifeless/bzr/bug-558343-wrong-host-with-proxy |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil | Approve | ||
bzr-core | Pending | ||
Review via email: mp+24938@code.launchpad.net |
Commit message
Fix lp: urls behind an https proxy.
Description of the change
This should fix using lp: urls from behind an https proxy; no tests - it appears remarkably opaque :(.
Would love vincent's opinion on it, as I think he knows urllib2 guts much better than I.
To post a comment you must log in.
Oh, and as I'm travelling to UDS, please land if its ok (or fix and land) - this is fairly high importance IMO.