Launchpad itself

Merge lp:~lifeless/launchpad/librarian into lp:launchpad

  1. librarian
  2. Merge into devel
Proposed by Robert Collins
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: no longer in the source branch.
Merged at revision: 11522
Proposed branch: lp:~lifeless/launchpad/librarian
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/canonical/launchpad/database/librarian.py (+1/-1)
To merge this branch: bzr merge lp:~lifeless/launchpad/librarian
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Review via email: mp+35053@code.launchpad.net

Description of the change

Avoid unnecessary work FTW.

I'll also propose for a CP after we see how much it helps edge.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Seems fine. Is it really going to make a CP-worthy difference? Hard to say I guess. Anyway, a clear improvement.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/database/librarian.py'
2--- lib/canonical/launchpad/database/librarian.py 2010-09-06 21:02:44 +0000
3+++ lib/canonical/launchpad/database/librarian.py 2010-09-10 00:36:28 +0000
4@@ -236,7 +236,7 @@
5
6 @property
7 def deleted(self):
8- return self.content is None
9+ return self.contentID is None
10
11 def __storm_invalidated__(self):
12 """Make sure that the file is closed across transaction boundary."""