Merge lp:~lifeless/launchpad/oops into lp:launchpad/db-devel
Proposed by
Robert Collins
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Robert Collins | ||||||||||||
Approved revision: | no longer in the source branch. | ||||||||||||
Merged at revision: | 9753 | ||||||||||||
Proposed branch: | lp:~lifeless/launchpad/oops | ||||||||||||
Merge into: | lp:launchpad/db-devel | ||||||||||||
Diff against target: |
407 lines (+127/-31) 11 files modified
lib/canonical/launchpad/doc/librarian.txt (+19/-0) lib/canonical/launchpad/webapp/errorlog.py (+5/-1) lib/canonical/librarian/client.py (+26/-7) lib/canonical/librarian/ftests/test_client.py (+3/-2) lib/lp/services/mail/sendmail.py (+20/-6) lib/lp/services/mail/tests/test_sendmail.py (+0/-4) lib/lp/services/memcache/client.py (+26/-1) lib/lp/services/memcache/tests/test_memcache_client.py (+19/-6) lib/lp/services/timeline/tests/test_timedaction.py (+4/-2) lib/lp/services/timeline/timedaction.py (+1/-1) lib/lp/testing/tests/test_testcase.py (+4/-1) |
||||||||||||
To merge this branch: | bzr merge lp:~lifeless/launchpad/oops | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | code | Approve | |
Tim Penhey (community) | release-critical | Approve | |
Graham Binns | release-critical | Pending | |
Review via email: mp+34635@code.launchpad.net |
Commit message
Change TimedAction.
Description of the change
Change TimedAction.
To post a comment you must log in.
=== modified file 'lib/lp/ services/ timeline/ tests/test_ timedaction. py' services/ timeline/ tests/test_ timedaction. py 2010-09-03 01:09:38 +0000 services/ timeline/ tests/test_ timedaction. py 2010-09-05 05:07:57 +0000
action. duration = datetime. timedelta( 0, 0, 0, 4)
self. assertEqual( 4, len(log_tuple), "!= 4 elements %s" % (log_tuple,))
self. assertAlmostEqu al(2, log_tuple[0]) stEqual( 4, log_tuple[1]) stEqual( 6, log_tuple[1])
self. assertEqual( "foo", log_tuple[2])
self. assertEqual( "bar", log_tuple[3])
--- lib/lp/
+++ lib/lp/
@@ -41,8 +41,10 @@
log_tuple = action.logTuple()
+ # The first element is the start offset in ms.
- self.assertAlmo
+ # The second element is the end offset in ms.
+ self.assertAlmo
@@ -56,6 +58,6 @@
self. assertEqual( 4, len(log_tuple), "!= 4 elements %s" % (log_tuple,))
self. assertAlmostEqu al(2, log_tuple[0]) stEqual( 999999, log_tuple[1]) stEqual( 1000001, log_tuple[1])
self. assertEqual( "foo", log_tuple[2])
self. assertEqual( "bar", log_tuple[3])
log_tuple = action.logTuple()
- self.assertAlmo
+ self.assertAlmo
=== modified file 'lib/lp/ services/ timeline/ timedaction. py' services/ timeline/ timedaction. py 2010-09-03 01:09:38 +0000 services/ timeline/ timedaction. py 2010-09-05 05:07:57 +0000 to_ms(self. duration)
--- lib/lp/
+++ lib/lp/
@@ -57,7 +57,7 @@
length = 999999
else:
length = self._td_
- return (offset, length, self.category, self.detail)
+ return (offset, offset + length, self.category, self.detail)
def _td_to_ms(self, td):
"""Tweak on a backport from python 2.7"""