Trojitá

trojita:master

  1. Git
  2. lp:trojita
  3. master
Last commit made on 2018-10-10
Get this branch:
git clone -b master https://git.launchpad.net/trojita

Branch information

Name:
master
Repository:
lp:trojita

Recent commits

76151f1... by l10n daemon script <email address hidden>

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

ca34db5... by l10n daemon script <email address hidden>

GIT_SILENT made messages (after extraction)

feb264c... by l10n daemon script <email address hidden>

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

42d768d... by Erik Quaeghebeur <email address hidden>

Transition test suite from QRegExp to QRegularExpression

Trojitá's main code has been ported transitioned from the
unmaintained QRegExp to the ‘new’ QRegularExpression. At that
time, the test suite was not yet transitioned to make sure no
bugs entered there and made bugs in the changed code invisible.

This patch transitions the test suite. A literal translation
has been done. So the new functionality of QRegularExpression
has not been used (specifically, multi-line support). This is
left for future patches.

Change-Id: I36a0480349ff348c673d117d228326b83672d4ab

fee56b6... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Ignore FIXMEs at lgtm.com

We're using these for writing down stuff which should be -- eventually
-- fixed, or as a TODO list. I've been doing that for 13+ years, and I
definitely won't be doing a tree-wide sed to make lgtm.com happy.

Change-Id: I921cdb211846e190b0e40cc7f3969f637cd17e36
Sort-of-fixes: https://lgtm.com/projects/g/KDE/trojita/alerts/?mode=list&rule=cpp%2Ffixme-comment

e27160d... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Add missing header guards

Change-Id: I2148001abaa6c4b47bb9c9dc0a8bf9862eb95e8a
Fixes: https://lgtm.com/projects/g/KDE/trojita/alerts/?mode=list&rule=cpp%2Fmissing-header-guard

3933d47... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Remove `const` from function return types

...because these have no effect.

Change-Id: Id0f92961aca55c873505e9d2eb17a19308ecfa3d
Fixes: https://lgtm.com/projects/g/KDE/trojita/alerts/?mode=list&rule=cpp%2Fmember-const-no-effect

f1c99fd... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Don't call a virtual method from constructor

The intention of that check was to prevent issuing a FETCH for parts
which have no fetchable content on their own (in IMAP terms). Having
that in place in constructor was just an optimization.

Let's move this into fetch() to prevent any confusion about consulting a
parent class type's implementation accidentally.

Thanks to lgtm.com for a nice catch.

Change-Id: I67097ee1e8fd8dec6dc5294add6956d01892dc78
Fixes: https://lgtm.com/projects/g/KDE/trojita/snapshot/20e1eb1eb357b662c07be39780d032d58e60ec7a/files/src/Imap/Model/MailboxTree.cpp#x58a977bed141c12b:1

272c3c0... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Merge changes from topic 'imap-wrong-bodystructure'

* changes:
  GUI: Special handling for parts whose MIME structure failed to parse
  IMAP: fall back to binary part rendering when BODYSTRUCTURE parsing fails

58e3b9b... by =?utf-8?q?Jan_Kundr=C3=A1t?= <email address hidden>

Merge changes from topic 'efail-mitigation'

* changes:
  crypto: EFAIL: clarify that we handle broken encrypted messages properly
  crypto: make the code-flow more descriptive