Mago

Merge lp:~mago-contributors/mago/mago-ldtp2 into lp:~mago-contributors/mago/mago-1.0

  1. mago-ldtp2
  2. Merge into mago-1.0
Proposed by James Tatum
Status: Merged
Merged at revision: not available
Proposed branch: lp:~mago-contributors/mago/mago-ldtp2
Merge into: lp:~mago-contributors/mago/mago-1.0
Diff against target: 54 lines (+7/-8)
1 file modified
mago/application/main.py (+7/-8)
To merge this branch: bzr merge lp:~mago-contributors/mago/mago-ldtp2
Reviewer Review Type Date Requested Status
Nagappan Alagappan Approve
Review via email: mp+18612@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Tatum (jtatum) wrote :

Changing launcher to use args parameter required in ldtp2.

Revision history for this message
Nagappan Alagappan (nagappan) wrote :

Sorry for the inconvenience in changing some of the arguments in LDTPv2.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mago/application/main.py'
2--- mago/application/main.py 2009-08-20 02:40:51 +0000
3+++ mago/application/main.py 2010-02-04 15:11:18 +0000
4@@ -19,7 +19,7 @@
5 """
6 CLOSE_TYPE = 'menu'
7 CLOSE_NAME = 'mnuQuit'
8- LAUNCHER_ARGS = ['']
9+ LAUNCHER_ARGS = []
10 WINDOW = ''
11 TOP_PANEL = 'frmTopExpandedEdgePanel'
12
13@@ -68,17 +68,16 @@
14 def open(self):
15 """
16 Given an application, it tries to open it.
17-
18 """
19 self._enable_a11y(True)
20- ldtp.launchapp(self.LAUNCHER, arg=self.LAUNCHER_ARGS)
21+ ldtp.launchapp(self.LAUNCHER, args=self.LAUNCHER_ARGS)
22 self._enable_a11y(False)
23
24 ldtp.wait(2)
25 response = ldtp.waittillguiexist(self.name, '', 20)
26-
27+
28 if response == 0:
29- raise ldtp.LdtpExecutionError, "The " + self.name + " window was not found."
30+ raise ldtp.LdtpExecutionError, "The " + self.name + " window was not found."
31
32 def is_opened(self):
33 """
34@@ -88,7 +87,7 @@
35
36 def close(self):
37 """
38- Given an application, it tries to close it.
39+ Given an application, it tries to close it.
40 """
41 try:
42 app = ooldtp.context(self.name)
43@@ -111,9 +110,9 @@
44
45 def save(self, save_menu='mnuSave'):
46 """
47- Given an application, it tries to save the current document.
48+ Given an application, it tries to save the current document.
49 This method gives very basic functionality. Please, override this method in the subclasses for error checking.
50-
51+
52 @type save_menu: string
53 @param save_menu: The name of the Save menu of the application. If not mentioned the default will be used ("Save").
54 """

Subscribers

People subscribed via source and target branches

to status/vote changes: