Merge lp:~mars/launchpad/add-py25-lint into lp:launchpad
Proposed by
Māris Fogels
Status: | Rejected |
---|---|
Rejected by: | Māris Fogels |
Proposed branch: | lp:~mars/launchpad/add-py25-lint |
Merge into: | lp:launchpad |
Diff against target: |
36 lines (+29/-0) 1 file modified
buildout-templates/bin/lint.sh.in (+29/-0) |
To merge this branch: | bzr merge lp:~mars/launchpad/add-py25-lint |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+36502@code.launchpad.net |
Description of the change
This branch adds a test for Python 2.5 incompatible code to the bin/lint.sh script.
I manually tested all of the execution paths in this patch. Python2.5 is not a
Launchpad development dependency, so a branch was included to make this check
conditional. pyflakes is used for the check, and pyflakes is in
launchpad-
--
Māris Fogels -- https:/
Launchpad.net -- cross-project collaboration and hosting
To post a comment you must log in.
Unmerged revisions
- 11620. By Māris Fogels
-
Added a check for Python 2.5 incompatible code to bin/lint.sh
Seems useful if we have two things:
- python 2.5 on the lucid builders
- it hooked into make check.
In the absence of both these things, I wouldn't bother.