Launchpad itself

Merge lp:~matthew.revell/launchpad/home-page-staging-popup-help into lp:launchpad

  1. home-page-staging-popup-help
  2. Merge into devel
Proposed by Matthew Revell
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merge reported by: Henning Eggers
Merged at revision: not available
Proposed branch: lp:~matthew.revell/launchpad/home-page-staging-popup-help
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~matthew.revell/launchpad/home-page-staging-popup-help
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve
Henning Eggers (community) code Approve
Review via email: mp+12233@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Matthew Revell (matthew.revell) wrote :

This changes the staging help link on the new home page to become a pop-up, rather than a link to the help wiki.

The main change is the addition of the pop-up help file lib/lp/registry/help/home-page-staging-help.html

Revision history for this message
Henning Eggers (henninge) wrote :

As discussed:
- /+help
- staging vs. sandbox.

Thanks for this improvement!

Henning

review: Approve (code)
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the fix Matthew. Here are some items for your consideration:

* day to day -> day-to-day/

* Each of the bullets should be little sentences, correct? I think they should be capitalized and all either end with a period or comma.

* I'd prefer 'the staging environment' -> 'https://staging.launchpad.net' so that the URL is visible without forcing them to click on it.

* The lack of an identified 'close' or 'X' on the pop-up is bothersome. Please file a bug about this problem and let's get a solution in ASAP. The problem is especially bad on Webkit-based browsers.

review: Approve (release-critical)
Revision history for this message
Matthew Revell (matthew.revell) wrote :

> Thanks for the fix Matthew. Here are some items for your consideration:

Thanks Brad.

> * day to day -> day-to-day/

Fixed.

> * Each of the bullets should be little sentences, correct? I think they
> should be capitalized and all either end with a period or comma.

The Oxford Style Guide gives examples of where you might use bullets as part of a sentence or give each bullet its own sentence. I agree that in this case each should be its own sentence.

> * I'd prefer 'the staging environment' -> 'https://staging.launchpad.net' so
> that the URL is visible without forcing them to click on it.

They can hover and, in any browser I use, get a preview of the link URL somewhere in the window but I've made the change.

> * The lack of an identified 'close' or 'X' on the pop-up is bothersome.
> Please file a bug about this problem and let's get a solution in ASAP. The
> problem is especially bad on Webkit-based browsers.

We have bug 406394, which is currently unassigned.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/templates/root-index.pt'
2--- lib/canonical/launchpad/templates/root-index.pt 2009-09-18 23:48:15 +0000
3+++ lib/canonical/launchpad/templates/root-index.pt 2009-09-22 16:17:36 +0000
4@@ -138,7 +138,7 @@
5 working within Launchpad.<br />
6 </tal:logged_out>You can test Launchpad's functionality
7 in our sandbox environment.
8- (<a href="https://help.launchpad.net/StagingServer">What's this?</a>)<br />
9+ (<a href="+help/home-page-staging-help.html" target="help">What is staging?</a>)<br />
10 <tal:logged_in condition="view/user" omit-tag="">
11 If you're ready, you can:
12 <ul tal:define="apphomes view/apphomes">
13
14=== added file 'lib/lp/registry/help/home-page-staging-help.html'
15--- lib/lp/registry/help/home-page-staging-help.html 1970-01-01 00:00:00 +0000
16+++ lib/lp/registry/help/home-page-staging-help.html 2009-09-22 16:17:36 +0000
17@@ -0,0 +1,30 @@
18+<html>
19+ <head>
20+ <title>Staging &mdash; Launchpad's sandbox</title>
21+ <link rel="stylesheet" type="text/css"
22+ href="/+icing/yui/current/build/cssreset/reset.css" />
23+ <link rel="stylesheet" type="text/css"
24+ href="/+icing/yui/current/build/cssfonts/fonts.css" />
25+ <link rel="stylesheet" type="text/css"
26+ href="/+icing/yui/current/build/cssbase/base.css" />
27+ </head>
28+ <body>
29+ <h1>Staging &mdash; Launchpad's sandbox</h1>
30+
31+ <p>
32+ If you want to try Launchpad out, you can use the <a href="https://staging.launchpad.net/" target="parent">staging environment</a> to experiment with real data and functionality, but without affecting the day to day work of other Launchpad users.
33+ </p>
34+
35+ <p>However, there are a few things to note about staging:</p>
36+
37+ <ul>
38+ <li>every 24 hours, staging's database is replaced with a fresh snapshot of Launchpad's production database: you will lose anything you do on staging</li>
39+ <li>staging runs the latest bleeding edge code from the Launchpad developers &mdash; if things go wrong, <a target="_blank" href="https://bugs.launchpad.net/launchpad/+filebug">please let us know</a></li>
40+ <li>you can't create a new account on staging &mdash; instead, create one in <a href="https://launchpad.net/">Launchpad's production environment</a> and then wait up to 24 hours for your account to be available on staging</li>
41+ <li>staging does not send email</li>
42+ <li>you can upload translations and templates but not export them &mdash; uploaded translations/templates will disappear after 24 hours</li>
43+ <li>to push code branches to staging you need use <code>bzr push lp://staging/~your-id/branch-name</code></li>
44+ </ul>
45+
46+ </body>
47+</html>