Bazaar GTK+ Frontends

Merge lp:~mbp/bzr-gtk/trivial into lp:bzr-gtk/gtk2

  1. trivial
  2. Merge into gtk2
Proposed by Martin Pool
Status: Rejected
Rejected by: Jelmer Vernooij
Proposed branch: lp:~mbp/bzr-gtk/trivial
Merge into: lp:bzr-gtk/gtk2
Diff against target: 11 lines (+1/-0)
1 file modified
__init__.py (+1/-0)
To merge this branch: bzr merge lp:~mbp/bzr-gtk/trivial
Reviewer Review Type Date Requested Status
Vincent Ladeuil Needs Information
Review via email: mp+18126@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

This declares gtk compatible with bzr 2.2.0. It probably is ;-)

Revision history for this message
Vincent Ladeuil (vila) wrote :

As long as bzrlib.api_minimum_version is :
  # API compatibility version
  api_minimum_version = (2, 1, 0)

there is no need for that.

Do we plan to change that early in the 2.2 cycle ?

review: Needs Information
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Review: Needs Information
> As long as bzrlib.api_minimum_version is :
> # API compatibility version
> api_minimum_version = (2, 1, 0)
>
> there is no need for that.
>
> Do we plan to change that early in the 2.2 cycle ?
>

I think we should.

But note that this changed 6 months ago and bzr-gtk didn't update for
that long...

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuFJVwACgkQJdeBCYSNAAMADQCgu7rVcKCZM5MymUZinOwWYpdY
95IAnjwWISqPztZ/lfE/XVGpOf6Mv9Vl
=Vm5H
-----END PGP SIGNATURE-----

Revision history for this message
Vincent Ladeuil (vila) wrote :

>>>>> "jam" == John A Meinel <email address hidden> writes:

    jam> Vincent Ladeuil wrote:
    >> Review: Needs Information
    >> As long as bzrlib.api_minimum_version is :
    >> # API compatibility version
    >> api_minimum_version = (2, 1, 0)
    >>
    >> there is no need for that.
    >>
    >> Do we plan to change that early in the 2.2 cycle ?
    >>

    jam> I think we should.

    jam> But note that this changed 6 months ago and bzr-gtk didn't update for
    jam> that long...

To be fair, bzr-gtk updated quite quickly but no *release* was
done with the fix.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This was already updated earlier, this data now lives in info.py.

Unmerged revisions

674. By Martin Pool

Assume this will work with bzrlib 2.2

Updating diff...

An updated diff will be available in a few minutes. Reload to see the changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '__init__.py'
2--- __init__.py 2009-12-03 09:33:17 +0000
3+++ __init__.py 2010-01-27 10:26:13 +0000
4@@ -73,6 +73,7 @@
5 (1, 15, 0),
6 (1, 17, 0),
7 (2, 1, 0),
8+ (2, 2, 0),
9 ]
10
11 bzrlib.api.require_any_api(bzrlib, COMPATIBLE_BZR_VERSIONS)

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: