Merge lp:~mbp/bzr/224373-2.2-ftp-response into lp:bzr/2.2
Proposed by
Martin Pool
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5078 |
Proposed branch: | lp:~mbp/bzr/224373-2.2-ftp-response |
Merge into: | lp:bzr/2.2 |
Diff against target: |
36 lines (+14/-1) 2 files modified
NEWS (+3/-0) bzrlib/transport/ftp/__init__.py (+11/-1) |
To merge this branch: | bzr merge lp:~mbp/bzr/224373-2.2-ftp-response |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Martin Packman (community) | Approve | ||
Review via email: mp+32731@code.launchpad.net |
Commit message
cope with ftp servers giving 250 reply for mkd (bug 224373)
Description of the change
Here's a workaround for MS FTP server's habit of returning '250' for successful mkd calls.
This is done 'blind' without a test and without testing it against a Microsoft ftp server, just based on the tracebacks and interactively creating an error that looks like them. If someone could actually test this, that would be good.
To post a comment you must log in.
Looked at this bug yesterday as well and this change is the same conclusion I'd drawn. Are you considering _setmode redundant as it's an win ftp server bug, or should that be called on this path as well?
Had looked at the ftp tests as well and bar subclassing both the medusa and pyftpdlib paths it didn't seem like this 'd be properly testable so just the fix is okay I think.