Bazaar

Merge lp:~mbp/bzr/progress into lp:bzr

  1. progress
  2. Merge into bzr.dev
Proposed by Martin Pool
Status: Merged
Approved by: John A Meinel
Approved revision: no longer in the revision history of the source branch.
Merged at revision: not available
Proposed branch: lp:~mbp/bzr/progress
Merge into: lp:bzr
Diff against target: 12 lines (+0/-5)
1 file modified
bzrlib/progress.py (+0/-5)
To merge this branch: bzr merge lp:~mbp/bzr/progress
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+20106@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

Kill off an unnecessary ancient dict of progressbar classes. The modern way is to create the right uifactory.

lp:~mbp/bzr/progress updated
5057. By Canonical.com Patch Queue Manager <email address hidden>

(mbp, for toshio) handle noise at the start of patches

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> Martin Pool has proposed merging lp:~mbp/bzr/progress into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
> Related bugs:
> #388266 many uses of DummyProgress are unnecessary
> https://bugs.launchpad.net/bugs/388266
>
>
> Kill off an unnecessary ancient dict of progressbar classes. The modern way is to create the right uifactory.
>

 merge: approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuHHYcACgkQJdeBCYSNAAPz1QCcCU7x/yv6HZW50vormIMHCSuv
7QQAnjyMb31UBOvtI/mBGFGhDHrTIckJ
=rl4f
-----END PGP SIGNATURE-----

review: Approve
lp:~mbp/bzr/progress updated
5058. By Canonical.com Patch Queue Manager <email address hidden>

(mbp) Delete ancient dict of progress bar classes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/progress.py'
2--- bzrlib/progress.py 2010-02-10 17:52:08 +0000
3+++ bzrlib/progress.py 2010-02-25 06:45:25 +0000
4@@ -316,8 +316,3 @@
5 else:
6 self.cur_phase += 1
7 self.pb.update(self.message, self.cur_phase, self.total)
8-
9-
10-_progress_bar_types = {}
11-_progress_bar_types['dummy'] = DummyProgress
12-_progress_bar_types['none'] = DummyProgress