Merge lp:~mbp/bzr/progress into lp:bzr/2.2
Proposed by
Martin Pool
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Vincent Ladeuil | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 5060 | ||||
Proposed branch: | lp:~mbp/bzr/progress | ||||
Merge into: | lp:bzr/2.2 | ||||
Diff against target: |
308 lines (+84/-87) 5 files modified
NEWS (+6/-0) bzrlib/progress.py (+0/-22) bzrlib/tests/test_progress.py (+37/-4) bzrlib/tests/test_ui.py (+4/-48) bzrlib/ui/text.py (+37/-13) |
||||
To merge this branch: | bzr merge lp:~mbp/bzr/progress | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil | Approve | ||
Review via email: mp+30181@code.launchpad.net |
Commit message
adjust spinner and repainting of progress bar
Description of the change
Based on <https:/
* spinner is now between the transport activity and the status message, so that it doesn't look like there's two spinners and one of them is stuck
* avoid truncating the numbers at the end of the progress bar
* delete the (deprecated since 2.1) ProgressTask.note
I think this is still safe for 2.2 since the only api change is to something already long deprecated.
To post a comment you must log in.
This seems to address more cases where a terminal doesn't allow using the full width which is good.
I'm still unclear about *where* exactly this is relevant but I think it's safer this way.
We may have complaints that we don't use the full available width but less than complaints about bad wrapping anyway.