Merge lp:~mguthart-x/ubuntu-docs/ubuntu-docs into lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

Proposed by Mark Guthart
Status: Merged
Approved by: Doug Smythies
Approved revision: 487
Merged at revision: 488
Proposed branch: lp:~mguthart-x/ubuntu-docs/ubuntu-docs
Merge into: lp:~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10
Diff against target: 176 lines (+30/-51)
5 files modified
ubuntu-help/C/unity-launcher-change-autohide.page (+3/-2)
ubuntu-help/C/unity-launcher-shapes.page (+4/-4)
ubuntu-help/C/unity-menubar-intro.page (+8/-5)
ubuntu-help/C/unity-scrollbars-intro.page (+5/-29)
ubuntu-help/C/unity-shopping.page (+10/-11)
To merge this branch: bzr merge lp:~mguthart-x/ubuntu-docs/ubuntu-docs
Reviewer Review Type Date Requested Status
Doug Smythies Approve
Gunnar Hjalmarsson Approve
Review via email: mp+289375@code.launchpad.net

This proposal supersedes a proposal from 2016-03-15.

Description of the change

Made updates/changes based on comments from previous merge request.

To post a comment you must log in.
Revision history for this message
Doug Smythies (dsmythies) wrote : Posted in a previous version of this proposal

I am not savvy enough to merge this into my stuff until my stuff is finished.

Evolution Calendar: I don't really know, but if I follow the link and try to do what it says, it doesn't work. i.e. I do get anywhere by clicking on the clock and then clicking on the first line.
Clicking on "about" in the calendar that seems to work, doesn't say anything about evolution.

Do the icons appear for you? My Xenial desktop doesn't show any properly, but my local HTML stuff does.

Click on top half or bottom half of slider: Agree. It is now superceeded by the below. But NOT for some apps, like firefox which still works the old way. I went to a known very long html page with firefox to confirm.

"Click the scrollbar to move the screen's position exactly where you want it": Oh yes, it works for me. But not with firefox, as stated above.

"unable to confirm disabling the new scrollbars is an option": me either. Seems to have no effect, nor is any warning or error message printed.

Revision history for this message
Doug Smythies (dsmythies) wrote : Posted in a previous version of this proposal

I can not figure out the missing icons issue on my 16.04 desktop.
They are fine on my 15.10 desktop.
The actual files themselves are there.
I did an update, just to be sure.

For others that might be reading this, I am talking about (help reference):
https://help.ubuntu.com/stable/ubuntu-help/unity-menubar-intro.html
"Status Menues"
and with "List of status menus and what they do" opened:
all the icons are not being displayed on my 16.04 desktop "help" version of the same page.

Can anyone confirm or deny for their computer?

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote : Posted in a previous version of this proposal

Thanks for your work with this, Mark! These are my comments at this time:

* Evolution
Evolution means the old Evolution mail/calendar client, not the new Calendar application. If you install Evolution (not installed by default) and mark the applicable option in Time & Date -> Clock, the clock will display coming events from Evolution.

* Scrollbar
The first item doesn't seem to work for me either. I'd suggest it's removed.
Your suggestion: "Click the scrollbar to move the screen's position exactly where you want it." I don't quite understand it. The only way I have found to move the position *exactly* where I want it is to drag the slider. What did I miss?
(@Doug: Doesn't Firefox use its own scrollbar feature?)
Also, disabling it seems to not work either, so that section should better be removed as well.

* Author/editor
You shouldn't put yourself as author of pages you only edited. Usually nowadays we put "Ubuntu Documentation Team" as the editor, instead of adding to long lists of individual editors. But if you want to mark yourself as "editor" (and keep the "author" as is), I'll accept it (even if I'd prefer "Ubuntu Documentation Team"...).

Mark, can you please make those changes and remove the comments?

@Doug: The icons on unity-menubar-intro.page don't show up for me either on 16.04. Another thing to follow up after tomorrow.

review: Needs Fixing
Revision history for this message
Mark Guthart (mguthart-x) wrote : Posted in a previous version of this proposal

Thank you Gunnar - I appreciate the guidance. Given this was my first
commit to this project, I went back and forth whether to update the author,
and ultimately decided to update it solely for visibility on who last
edited it was all.

*Scrollbar
What I was finding on my 16.04 build was if I click somewhere on the
scrollbar (not the thumb slider, but the scrollbar itself), it would move
the thumb slider to that position where I clicked - effectively moving the
screen's position to where the click was made. I did not test this in an
application like Firefox, but rather while navigating files on the hard
drive itself. I'll review the text and see whether it's valuable - if it
adds too much confusion it may be better to simply remove it.

I also am going to look back at those pages and check the terminology used
for the "system menu". If I recall it talks about the icon in the upper
right corner of the menu bar, which is fine, but I found that
shell-exit.page uses the terminology of "system menu" for navigating users.
I'd like to update the unity pages so they are consistent with that.

Thank you again. I should be able to get those changes taken care of later
this afternoon my time (in the U.S.).

Mark

On Wed, Mar 16, 2016 at 11:15 AM, Gunnar Hjalmarsson <
<email address hidden>> wrote:

> Review: Needs Fixing
>
> Thanks for your work with this, Mark! These are my comments at this time:
>
> * Evolution
> Evolution means the old Evolution mail/calendar client, not the new
> Calendar application. If you install Evolution (not installed by default)
> and mark the applicable option in Time & Date -> Clock, the clock will
> display coming events from Evolution.
>
> * Scrollbar
> The first item doesn't seem to work for me either. I'd suggest it's
> removed.
> Your suggestion: "Click the scrollbar to move the screen's position
> exactly where you want it." I don't quite understand it. The only way I
> have found to move the position *exactly* where I want it is to drag the
> slider. What did I miss?
> (@Doug: Doesn't Firefox use its own scrollbar feature?)
> Also, disabling it seems to not work either, so that section should better
> be removed as well.
>
> * Author/editor
> You shouldn't put yourself as author of pages you only edited. Usually
> nowadays we put "Ubuntu Documentation Team" as the editor, instead of
> adding to long lists of individual editors. But if you want to mark
> yourself as "editor" (and keep the "author" as is), I'll accept it (even if
> I'd prefer "Ubuntu Documentation Team"...).
>
> Mark, can you please make those changes and remove the comments?
>
> @Doug: The icons on unity-menubar-intro.page don't show up for me either
> on 16.04. Another thing to follow up after tomorrow.
> --
>
> https://code.launchpad.net/~mguthart-x/ubuntu-docs/ubuntu-docs/+merge/289008
> You are the owner of lp:~mguthart-x/ubuntu-docs/ubuntu-docs.
>

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote : Posted in a previous version of this proposal

On 2016-03-16 18:45, Mark Guthart wrote:
> What I was finding on my 16.04 build was if I click somewhere on the
> scrollbar (not the thumb slider, but the scrollbar itself), it would move
> the thumb slider to that position where I clicked - effectively moving the
> screen's position to where the click was made.

I couldn't reproduce that behavior. I used "Files" and navigated to /usr/bin (which makes up a really long page).

> I also am going to look back at those pages and check the terminology used
> for the "system menu". If I recall it talks about the icon in the upper
> right corner of the menu bar, which is fine, but I found that
> shell-exit.page uses the terminology of "system menu" for navigating users.
> I'd like to update the unity pages so they are consistent with that.

Yeah, "System menu" is fine. We used that other wording when we didn't know the name of the thing, and it was never altered afterwards. Great if you change it on the Unity pages.

Revision history for this message
Doug Smythies (dsmythies) wrote : Posted in a previous version of this proposal

> I couldn't reproduce that behavior.
> I used "Files" and navigated to /usr/bin (which makes up a really long page).

Strangely enough, I used the exact same way, "Files" and /usr/bin for my tests.

We need to figure this out, because I get the behavior Mark gets.

>(@Doug: Doesn't Firefox use its own scrollbar feature?)

I guess so.

Calendar: I did set myself an appointment in whatever the default is, and it did appear when I clicked on the clock.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote : Posted in a previous version of this proposal

Tried the scrollbar again. Same behavior as previously.

If I open "Files" and navigate to /usr/bin, I see the first files/folders (alphabetically sorted). If I click the scrollbar in the middle, it takes me to the middle of *the whole list of files/folders*, which is far from the files/folders which were previously showed at the spot where I clicked.

Probably we are talking past one another.

Interesting about the new Calendar app. Apparently it is automatically synchronized with the Clock, which is news to me. Hence I think we should refer to the Calendar app instead of Evolution. (If we have time to do it...)

Revision history for this message
Doug Smythies (dsmythies) wrote : Posted in a previous version of this proposal

> Tried the scrollbar again. Same behavior as previously.
>
> If I open "Files" and navigate to /usr/bin, I see the first files/folders
> (alphabetically sorted). If I click the scrollbar in the middle, it takes me
> to the middle of *the whole list of files/folders*, which is far from the
> files/folders which were previously showed at the spot where I clicked.

Yes, exactly. And that is the "New" behavior, and is a description Mark is attempting to add with this MP.

Note the behavior is the same on 15.10.

However, go back to 14.04 and the behavior is different, going to the one page per top or bottom half click method (it isn't exactly like that but close enough). I assume that is the "old" way.

As both Mark and I have mentioned, we can not make the "old" way work as described, and so the proposal is that section should be deleted.

Revision history for this message
Doug Smythies (dsmythies) wrote :

Mark, This looks good to me. I'm going to merge it locally, and them update my web server development version of help.ubuntu.com so that I can look at it formatted. Then, and if Gunnar didn't do it already, I'll approve and merge.

By the way: I find the autohide mode of the launcher extremely annoying. Even at max sensitivity, I can not get it to show on my 16.04 Desktop VM. On my real physical 16.04 Desktop, it is difficult.

I looked around for any bug report or whatever for setting scroll bars to normal, just in case we are deleting something that is just broken at the moment. I didn't find anything.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Looks fine to me too. I give up about "exactly where you want it" and let you guys decide. ;)

Great if you can handle the merge, Doug. (Working on keyboard-layouts.page right now.)

review: Approve
Revision history for this message
Doug Smythies (dsmythies) wrote :

Mark,

I am going to make a further edit to unity-scrollbars-intro.page. Ways to use the scrollbars: - Step 3 no longer works and has been superseded by the new step 2 way. (as a sanity check - I tested and it works on mt 14.04 VM)

Validation check O.K.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-help/C/unity-launcher-change-autohide.page'
2--- ubuntu-help/C/unity-launcher-change-autohide.page 2014-02-18 22:04:17 +0000
3+++ ubuntu-help/C/unity-launcher-change-autohide.page 2016-03-17 14:39:18 +0000
4@@ -18,13 +18,14 @@
5 <title>Auto-hide the Launcher</title>
6
7 <p>You can hide the <gui>Launcher</gui> if you only want to see it when you move your
8- mouse or touchpad pointer to the left side of the screen.</p>
9+ mouse or touchpad pointer to either the left side or top left corner of the screen.</p>
10
11 <steps>
12- <item><p>Click the icon at the very right of the <gui>menu bar</gui> and select <gui>System Settings</gui>.</p></item>
13+ <item><p>Click the <gui>system menu</gui> at the very right of the <gui>menu bar</gui> and select <gui>System Settings</gui>.</p></item>
14 <item><p>In the Personal section, click <gui>Appearance</gui>.</p></item>
15 <item><p>Switch to the <gui>Behavior</gui> tab.</p></item>
16 <item><p>Switch <gui>Auto-hide the Launcher</gui> on.</p></item>
17+ <item><p>Select <gui>Left side</gui> or <gui>Top left corner</gui> to designate the reveal location for the <gui>Launcher</gui>.</p></item>
18 </steps>
19
20 <p>To help prevent you from accidentally showing the Launcher, Ubuntu requires you to
21
22=== modified file 'ubuntu-help/C/unity-launcher-shapes.page'
23--- ubuntu-help/C/unity-launcher-shapes.page 2015-03-02 17:05:23 +0000
24+++ ubuntu-help/C/unity-launcher-shapes.page 2016-03-17 14:39:18 +0000
25@@ -21,10 +21,10 @@
26 Ubuntu is starting your application. This is useful because while some applications start immediately,
27 others may take a minute to load.</p>
28
29- <p>Once the application has finished starting, a small <em>white triangle</em> will show
30- to the left of the Launcher square.
31- Two triangles means that you have two windows of the same application open.
32- If you have three or more windows of the same application open, three triangles will show.</p>
33+ <p>Once the application has finished starting, a set of small <em>white triangles</em> will show
34+ to the left and right of the Launcher square.
35+ Additional triangles will appear on the left of the Launcher square as additional windows of the same application are open (i.e. two triangles means that you have two windows of the same application open; three triangles means three windows).
36+ If you have more than three windows of the same application open, only three triangles will show.</p>
37
38 <note style="tip"><p>Applications that aren't currently running have translucent Launcher icon squares.
39 When an application is running, the Launcher icon square is full of color.</p></note>
40
41=== modified file 'ubuntu-help/C/unity-menubar-intro.page'
42--- ubuntu-help/C/unity-menubar-intro.page 2014-03-29 22:39:47 +0000
43+++ ubuntu-help/C/unity-menubar-intro.page 2016-03-17 14:39:18 +0000
44@@ -41,12 +41,12 @@
45 especially valuable on small screens like netbooks.
46 </p>
47
48- <p>If you want, you can change the default behavior, and have your menus attached
49- to the window title bar of respective application instead of the menu bar.</p>
50+ <p>If you want, you can change the default behavior to having your menus attached
51+ to the window title bar of respective application instead of the menu bar, and setting the visibility to always displayed instead of only displayed on mouse hovering. </p>
52
53 <steps>
54 <item>
55- <p>Click the icon at the very right of the menu bar and select
56+ <p>Click the <gui>system menu</gui> at the very right of the <gui>menu bar</gui> and select
57 <gui>System Settings</gui>.</p>
58 </item>
59 <item>
60@@ -56,6 +56,9 @@
61 <item>
62 <p>Under <gui>Show the menus for a window</gui>, select <gui>In the window's title bar</gui>.</p>
63 </item>
64+ <item>
65+ <p>Under <gui>Menus visibility</gui>, select <gui>Always displayed</gui>.</p>
66+ </item>
67 </steps>
68
69 </section>
70@@ -109,8 +112,8 @@
71
72 <item>
73 <p><em>Clock</em></p>
74- <p>Access the current time and date. Appointments from your
75- <link xref="clock-calendar">Evolution calendar</link> can also display here.</p>
76+ <p>Access the current time and date. Appointments from the built in
77+ <link xref="clock-calendar">Calendar application</link> can also display here.</p>
78 </item>
79
80 <item>
81
82=== modified file 'ubuntu-help/C/unity-scrollbars-intro.page'
83--- ubuntu-help/C/unity-scrollbars-intro.page 2014-03-19 19:18:01 +0000
84+++ ubuntu-help/C/unity-scrollbars-intro.page 2016-03-17 14:39:18 +0000
85@@ -43,40 +43,16 @@
86 <list>
87 <title>Ways to use the scrollbars:</title>
88 <item><p>
89- Click the top half of the <gui>thumb slider</gui> to scroll one page up. Click the bottom half to scroll one page down.
90- </p></item>
91- <item><p>
92 Drag the <gui>thumb slider</gui> up or down to move the screen's position exactly where you want it.
93 </p></item>
94 <item><p>
95+ Click the scrollbar to move the screen's position exactly where you want it.
96+ </p></item>
97+ <item><p>
98 <link xref="mouse-middleclick"/> on the <gui>thumb slider</gui> to move the screen's position without needing to drag or
99 scroll page by page. This is especially useful in long documents.
100 </p></item>
101 </list>
102-</section>
103-
104-<section id="disable-scrollbars">
105- <title>Disable the scrollbars</title>
106-
107- <p>You can disable the new scrollbars if you prefer the traditional style:</p>
108-
109- <steps>
110- <item><p>Open the <app>Terminal</app> by pressing <keyseq><key>Ctrl</key><key>Alt</key><key>t</key></keyseq>
111- or by searching for <input>terminal</input> in the <gui>Dash</gui>.
112- </p></item>
113- <item><p>Type the following command and press <key>Enter</key>:</p>
114-<code its:translate="no">gsettings set com.canonical.desktop.interface scrollbar-mode normal</code>
115- </item>
116- </steps>
117-
118- <p>If you change your mind and want to re-enable the scrollbars, run this command:</p>
119-
120- <code its:translate="no">gsettings reset com.canonical.desktop.interface scrollbar-mode</code>
121-
122-
123- <note style="tip">
124- <p>Setting your theme to <link xref="a11y-contrast">High Contrast</link> will also disable the overlay scrollbars.</p>
125- </note>
126-
127-</section>
128+</section>
129+
130 </page>
131
132=== modified file 'ubuntu-help/C/unity-shopping.page'
133--- ubuntu-help/C/unity-shopping.page 2014-04-03 12:45:06 +0000
134+++ ubuntu-help/C/unity-shopping.page 2016-03-17 14:39:18 +0000
135@@ -25,7 +25,7 @@
136 <title>Why are there shopping links in the Dash?</title>
137
138 <p>In addition to helping you find apps or files on your computer, the
139-<gui>Dash</gui> also shows you related online results for your searches.
140+<gui>Dash</gui> can also show you related online results for your searches.
141 Online sources include Amazon.com and dozens of other online sources.</p>
142
143 <p>When you purchase music or products from these sources, Canonical
144@@ -34,23 +34,22 @@
145 continues to support the Ubuntu project, then uses this money to make
146 Ubuntu better.</p>
147
148-<section id="disable-shopping">
149- <title>Turn off online search results</title>
150-
151- <p>If you don't want to receive online search suggestions, you can
152- disable this feature.</p>
153+<p>By default, the inclusion of online search results is turned off.</p>
154+
155+<section id="enable-shopping">
156+ <title>Turn on online search results</title>
157+
158+ <p>If you want to receive online search suggestions, you can
159+ enable this feature through the <gui>Security &amp; Privacy</gui> system setting.</p>
160
161 <steps>
162
163- <item><p>Click the icon at the far right of the <gui>menu bar</gui> and
164+ <item><p>Click the <gui>system menu</gui> at the far right of the <gui>menu bar</gui> and
165 select <gui>System Settings</gui>.</p></item>
166
167 <item><p>Open <gui>Security &amp; Privacy</gui> and select the <gui>Search</gui> tab.</p></item>
168
169- <item><p>Switch off <gui>Include online search results</gui>.</p></item>
170-
171- <item><p><link xref="shell-exit">Log out</link> and log back in for the
172- change to take effect.</p></item>
173+ <item><p>Switch on <gui>Include online search results</gui>.</p></item>
174
175
176 </steps>

Subscribers

People subscribed via source and target branches