Merge lp:~michael.nelson/launchpad/494391-ugly-upload-error-message into lp:launchpad
Proposed by
Michael Nelson
Status: | Merged |
---|---|
Approved by: | Michael Nelson |
Approved revision: | not available |
Merged at revision: | not available |
Proposed branch: | lp:~michael.nelson/launchpad/494391-ugly-upload-error-message |
Merge into: | lp:launchpad |
Diff against target: |
72 lines (+33/-4) 2 files modified
lib/lp/archiveuploader/tests/test_permission.py (+0/-4) lib/lp/archiveuploader/tests/test_uploadprocessor.py (+33/-0) |
To merge this branch: | bzr merge lp:~michael.nelson/launchpad/494391-ugly-upload-error-message |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Henning Eggers (community) | code | Approve | |
Review via email: mp+18831@code.launchpad.net |
Commit message
Ensure that uploads to invalid pockets are reported correctly in the rejection email.
To post a comment you must log in.
This fix for this branch actually landed with:
https:/ /code.edge. launchpad. net/~michael. nelson/ launchpad/ create- source- recipe- build2/ +merge/ 18535
as part of a cleanup (see lines 16-33 of the MP diff), but wasn't tested.
This branch just adds a test to ensure the exception is correctly printed in the email (as per bug 494391).
Small drive-by removing some redundant test-code and old lint.