Merge lp:~michael.nelson/launchpad/db-598464-priv-xmlrpc-access-getOrCreate into lp:launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Michael Nelson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 9526 |
Proposed branch: | lp:~michael.nelson/launchpad/db-598464-priv-xmlrpc-access-getOrCreate |
Merge into: | lp:launchpad/db-devel |
Prerequisite: | lp:~michael.nelson/launchpad/db-598464-get-or-create-from-identity |
Diff against target: |
323 lines (+229/-1) 8 files modified
lib/canonical/launchpad/interfaces/launchpad.py (+3/-0) lib/canonical/launchpad/xmlrpc/application.py (+6/-0) lib/canonical/launchpad/xmlrpc/configure.zcml (+3/-0) lib/canonical/launchpad/xmlrpc/faults.py (+11/-0) lib/lp/registry/configure.zcml (+10/-0) lib/lp/registry/interfaces/person.py (+24/-1) lib/lp/registry/tests/test_xmlrpc.py (+125/-0) lib/lp/registry/xmlrpc/softwarecenteragent.py (+47/-0) |
To merge this branch: | bzr merge lp:~michael.nelson/launchpad/db-598464-priv-xmlrpc-access-getOrCreate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+29059@code.launchpad.net |
Description of the change
Overview
========
This branch is related to bug 598464 and follows on from the MP at:
It aims to enable the software-
Issue
=====
Initially I'd tried restricting the rpc call to the agent only, but then realised the reason that I couldn't find any examples in the code for other private xmlrpc services was that it's unnecessary (given that the private service is only accessible internally).
To test:
bin/test -vvm test_xmlrpc
(13:09:31) adeuring: noodles775: again, a nice branch. But I think it is a bit odd to have a class PersonSetAPIView (ie.e.,a quite generic name) where the method getorCreateByOp enIDIdentifier( ) unconditionally providesthe rationale "software centerpurchase" as a account creation rationale. Shouldn't we either make the class name more specific or provide the rationale as a parameter of the method? oftwarePurchase ()) plication' identifying who uses them. AgentAPI, http:// ..../softwarece nteragent etc.? AgentApplicatio n... Customer( )?
(13:10:47) adeuring: (or use a method name like getOrCreateForS
(13:45:12) noodles775: adeuring: yes - I thought the same when I pushed the last rev. So I'd be keen to change the application name... most of the other private xmlrpc apps have names like 'ICodehostingAp
(13:46:42) noodles775: So perhaps, ISoftwareCenter
(13:47:07) adeuring: noodles775: ok, so something like s/Person/Shopper/ ?
(13:48:29) noodles775: The app name usually matches the API, so perhaps ISoftwareCenter
(13:50:06) adeuring: noodles775: ah, right. so, that, combined with a method name like getOrCreateShop
(13:50:20) noodles775: Sounds good.