LAZR Javascript Library

Merge lp:~michael.nelson/lazr-js/434519-overlay-alignment into lp:lazr-js

  1. 434519-overlay-alignment
  2. Merge into toolchain
Proposed by Michael Nelson
Status: Merged
Merged at revision: not available
Proposed branch: lp:~michael.nelson/lazr-js/434519-overlay-alignment
Merge into: lp:lazr-js
Diff against target: None lines
To merge this branch: bzr merge lp:~michael.nelson/lazr-js/434519-overlay-alignment
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve
Martin Albisetti (community) code/ui Approve
Review via email: mp+12268@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Simply ensures that the default text-alignment for overlays is left, rather than inheriting from the parent.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> Simply ensures that the default text-alignment for overlays is left, rather
> than inheriting from the parent.

Some more info:

This is a fix for bug 434519 - since we use yui grids with 3-0 templates, the default text-align is set to center on the body element by yui/cssgrids/grids.css.

Revision history for this message
Martin Albisetti (beuno) wrote :

Perfect, thank you.

review: Approve (code/ui)
Revision history for this message
Brad Crittenden (bac) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/overlay/assets/pretty-overlay-core.css'
2--- src/overlay/assets/pretty-overlay-core.css 2009-02-20 17:13:21 +0000
3+++ src/overlay/assets/pretty-overlay-core.css 2009-09-23 09:55:35 +0000
4@@ -13,6 +13,7 @@
5 /* overlay appears above blocking-div. */
6 .yui-pretty-overlay {
7 z-index: 1000;
8+ text-align: left;
9 }
10
11 /* Ensure that td has no border (YUI base css adds one). */

Subscribers

People subscribed via source and target branches