Merge lp:~mterry/appmenu-gtk/cancellable-register-window into lp:appmenu-gtk/0.4
Proposed by
Michael Terry
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould | ||||
Approved revision: | 122 | ||||
Merge reported by: | Sebastien Bacher | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~mterry/appmenu-gtk/cancellable-register-window | ||||
Merge into: | lp:appmenu-gtk/0.4 | ||||
Diff against target: |
180 lines (+66/-41) 1 file modified
src/bridge.c (+66/-41) |
||||
To merge this branch: | bzr merge lp:~mterry/appmenu-gtk/cancellable-register-window | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+52248@code.launchpad.net |
To post a comment you must log in.
A quick comment about this branch: it fixed the bug for the reporter, though that user then experienced a different crash that he has not been able to reproduce. So this should get a thorough lookover.
Logic seems sound to me though. Basically, the callback for RegisterWindow needs to be cancelled on dispose.