Launchpad itself

Merge lp:~mwhudson/launchpad/ChoiceSource-flexibility into lp:launchpad

  1. ChoiceSource-flexibility
  2. Merge into devel
Proposed by Ian Booth
Status: Merged
Merged at revision: 13847
Proposed branch: lp:~mwhudson/launchpad/ChoiceSource-flexibility
Merge into: lp:launchpad
Diff against target: 34 lines (+6/-4)
1 file modified
lib/lp/app/javascript/choiceedit/choiceedit.js (+6/-4)
To merge this branch: bzr merge lp:~mwhudson/launchpad/ChoiceSource-flexibility
Reviewer Review Type Date Requested Status
Ian Booth (community) code Approve
Review via email: mp+73611@code.launchpad.net

Commit message

[r=wallyworld][bug=839190] Make the ChoiceSource js widget slightly more reusable.

Description of the change

Hi, these small changes make ChoiceSource reusable in a greasemonkey script what I wrote (screenie here: http://people.linaro.org/~mwh/work_item_editor.png).

They should be harmless to other usages in lp.

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) wrote :

Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/app/javascript/choiceedit/choiceedit.js'
2--- lib/lp/app/javascript/choiceedit/choiceedit.js 2011-08-09 14:18:02 +0000
3+++ lib/lp/app/javascript/choiceedit/choiceedit.js 2011-08-31 23:48:25 +0000
4@@ -146,6 +146,10 @@
5
6 clickable_content: {
7 value: true
8+ },
9+
10+ zIndex: {
11+ value: 1000
12 }
13 };
14
15@@ -158,9 +162,6 @@
16 * @preventable _saveData
17 */
18 this.publish(SAVE);
19-
20- var editicon = this.get('editicon');
21- editicon.original_src = editicon.get("src");
22 },
23
24 /**
25@@ -245,7 +246,8 @@
26 title: this.get("title"),
27 items: this.get("items"),
28 value_location: this.get("value_location"),
29- progressbar: false
30+ progressbar: false,
31+ zIndex: this.get("zIndex")
32 });
33
34 var that = this;