Merge lp:~mwhudson/launchpad/codebrowse-fd-leak into lp:launchpad/db-devel
Proposed by
Michael Hudson-Doyle
| Status: | Merged |
|---|---|
| Approved by: | Tim Penhey |
| Approved revision: | not available |
| Merged at revision: | not available |
| Proposed branch: | lp:~mwhudson/launchpad/codebrowse-fd-leak |
| Merge into: | lp:launchpad/db-devel |
| To merge this branch: | bzr merge lp:~mwhudson/launchpad/codebrowse-fd-leak |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Hi,
This branch fixes a fd-leak in codebrowse by using one underlying branch transport per thread, rather than making a new transport per thread. It's not obvious to me why the transports are leaking, but this should fix the problem.
Cheers,
mwh
To post a comment you must log in.
Merged locally to check the diff since the scanner is still backed up.
Seems fine, although like you I can't see why the file descriptors are never released.
Since this is working on production, I say land it.