Merge lp:~mwhudson/launchpad/fewer-spurious-partial-code-imports-bug-532402 into lp:launchpad
Proposed by
Michael Hudson-Doyle
Status: | Merged |
---|---|
Approved by: | Michael Hudson-Doyle |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~mwhudson/launchpad/fewer-spurious-partial-code-imports-bug-532402 |
Merge into: | lp:launchpad |
Diff against target: |
18 lines (+2/-1) 1 file modified
lib/lp/codehosting/codeimport/worker.py (+2/-1) |
To merge this branch: | bzr merge lp:~mwhudson/launchpad/fewer-spurious-partial-code-imports-bug-532402 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+21416@code.launchpad.net |
Commit message
Capture the revision id used for determining whether all revisions were imported before running the import, to avoid semi-spurious reports of partial success.
Description of the change
Hi, see the linked bug for the explanation.
Do you think this needs a test?
To post a comment you must log in.
Umm, gut says we should have a test, but damn hard to get it right, so... my answer is no.